(fixes #1119) Ignore dependencies into dbt schemas from external schemas #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
commented
Nov 13, 2018
dbt/adapters/postgres/impl.py
Outdated
| self.cache.add_link(dependent, referenced) | ||
|
|
||
| # don't record in cache if this relation isn't in a relevant schema | ||
| if refed_schema in schemas: |
There was a problem hiding this comment.
@beckjake do you think we need to do a case-insensitive check here?
There was a problem hiding this comment.
Yeah, it needs to be refed_schema.lower() in schemas.
|
Thanks so much for quickly diagnosing and resolving this (obscure) issue! |
|
Tested this branch with the same command and it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1119 by checking the schema name of the downstream relation. If it is not in the list of schemas that dbt cares about, it is discarded.