Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipdb to dev requirements so it shows up in test docker containers #1188

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

beckjake
Copy link
Contributor

Since I end up manually editing my dev_requirements.txt to add this line every time I switch branches as it is, let's just put it in permanently. Getting dependencies into the tests' tox environments is a huge hassle and this makes debugging unit/integration test failures so much more pleasant. I left the version unspecified because we don't actually use this dependency, it's purely about developer quality of life.

@drewbanin drewbanin self-requested a review December 13, 2018 17:41
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@beckjake beckjake merged commit 08913bf into dev/grace-kelly Dec 13, 2018
@beckjake beckjake deleted the ipdb-dev-requirement branch December 13, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants