Skip to content

Conversation

@QMalcolm
Copy link
Contributor

Resolves #12042
Resolves #12037

Problem

There are three distinct types of functions: scalar, aggregate, and table. We need to know which the user is specifying. Of note, the only built-in supported type in dbt-adapters currently is scalar.

Solution

  • Add a type property to function nodes
  • The type function node property supports values: scalar, aggregate, and `table
  • The type function node property defaults to scalar if not explicitly specified

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@QMalcolm QMalcolm requested review from a team as code owners September 26, 2025 19:35
@cla-bot cla-bot bot added the cla:yes label Sep 26, 2025
@github-actions
Copy link
Contributor

Additional Artifact Review Required

Changes to artifact directory files requires at least 2 approvals from core team members.

@QMalcolm QMalcolm added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Sep 26, 2025
@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (e949d1a) to head (8baf375).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12057      +/-   ##
==========================================
+ Coverage   91.87%   91.89%   +0.01%     
==========================================
  Files         203      203              
  Lines       24792    24802      +10     
==========================================
+ Hits        22778    22792      +14     
+ Misses       2014     2010       -4     
Flag Coverage Δ
integration 88.78% <100.00%> (+0.02%) ⬆️
unit 65.21% <90.90%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 65.21% <90.90%> (+0.01%) ⬆️
Integration Tests 88.78% <100.00%> (+0.02%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@QMalcolm QMalcolm merged commit 8c929c3 into main Sep 26, 2025
65 checks passed
@QMalcolm QMalcolm deleted the qmalcolm--12042-add-function-type branch September 26, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UDFs] add function type property [UDFs] Ability to specify a UDF type

4 participants