Skip to content

Conversation

@QMalcolm
Copy link
Contributor

Resolves #12118

Problem

We were still supporting python 3.9 even though it is EOL

Solution

Drop support for python 3.9

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@QMalcolm QMalcolm requested a review from a team as a code owner October 27, 2025 21:25
@cla-bot cla-bot bot added the cla:yes label Oct 27, 2025
@QMalcolm QMalcolm changed the title Qmalcolm 12118 drop python 3.9 support Drop python 3.9 support Oct 27, 2025
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.88%. Comparing base (2190fa6) to head (3738429).
⚠️ Report is 3 commits behind head on main.

❌ Your patch status has failed because the patch coverage (60.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12120      +/-   ##
==========================================
+ Coverage   91.86%   91.88%   +0.01%     
==========================================
  Files         203      203              
  Lines       24846    24846              
==========================================
+ Hits        22826    22829       +3     
+ Misses       2020     2017       -3     
Flag Coverage Δ
integration 88.75% <60.00%> (+0.01%) ⬆️
unit 65.15% <60.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 65.15% <60.00%> (ø)
Integration Tests 88.75% <60.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@QMalcolm QMalcolm force-pushed the qmalcolm--12118-drop-python-3.9-support branch from fef66f8 to 55e9806 Compare October 28, 2025 15:16
MichelleArk
MichelleArk previously approved these changes Oct 28, 2025
@QMalcolm QMalcolm merged commit 4693918 into main Oct 28, 2025
57 of 60 checks passed
@QMalcolm QMalcolm deleted the qmalcolm--12118-drop-python-3.9-support branch October 28, 2025 20:10
WilliamDee pushed a commit that referenced this pull request Oct 30, 2025
* Update `setup.py` to drop support for python 3.9

* Update github issue templates to not use python 3.9 as an example

* Update github workflows to no longer depend on or test python 3.9

* Drop python 3.9 from the test dockerfile

* Update `CONTRIBUTING.md` to correctly list what python versions we test

* Update comment about some code specifically needed for a python 3.9.7 issue

* Update pre-commit python version comment

* Add changie doc

* Update imports from click as upgrading to python 3.10 changed some click items
WilliamDee pushed a commit that referenced this pull request Oct 30, 2025
* Update `setup.py` to drop support for python 3.9

* Update github issue templates to not use python 3.9 as an example

* Update github workflows to no longer depend on or test python 3.9

* Drop python 3.9 from the test dockerfile

* Update `CONTRIBUTING.md` to correctly list what python versions we test

* Update comment about some code specifically needed for a python 3.9.7 issue

* Update pre-commit python version comment

* Add changie doc

* Update imports from click as upgrading to python 3.10 changed some click items
WilliamDee pushed a commit that referenced this pull request Oct 30, 2025
* Update `setup.py` to drop support for python 3.9

* Update github issue templates to not use python 3.9 as an example

* Update github workflows to no longer depend on or test python 3.9

* Drop python 3.9 from the test dockerfile

* Update `CONTRIBUTING.md` to correctly list what python versions we test

* Update comment about some code specifically needed for a python 3.9.7 issue

* Update pre-commit python version comment

* Add changie doc

* Update imports from click as upgrading to python 3.10 changed some click items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.9

3 participants