Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stringified meta field with the actual meta field. #6804

Closed
wants to merge 2 commits into from

Conversation

tmastny
Copy link
Contributor

@tmastny tmastny commented Jan 31, 2023

resolves #6803

Description

Replaces the stringifyed meta field with the actual meta field.

Logging before:

 "meta": {"owners": "['team1', 'team2']"}

Logging after:

"meta": {"owners": ["team1", "team2"]}

In the original PR, there was some concern about logging without stringifying, but I've tested it (manually and with a functional test) and it works.

Checklist

@tmastny tmastny requested review from a team as code owners January 31, 2023 18:24
@cla-bot cla-bot bot added the cla:yes label Jan 31, 2023
@tmastny tmastny marked this pull request as draft February 15, 2023 17:27
@tmastny tmastny closed this Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1983] [Feature] Log the meta-dictionary instead of stringifying
1 participant