Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse command should return manifest when invoked via dbtRunner #7314

Merged
merged 5 commits into from
Apr 11, 2023

Conversation

iknox-fa
Copy link
Contributor

@iknox-fa iknox-fa commented Apr 10, 2023

resolves #6547

Description

Allows easy programmatic access to the manifest as generated by the cli.requires.manifest decorator. Currently a very, VERY simple implementation.

Checklist

@cla-bot cla-bot bot added the cla:yes label Apr 10, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

core/dbt/cli/main.py Outdated Show resolved Hide resolved
@iknox-fa iknox-fa marked this pull request as ready for review April 11, 2023 14:57
@iknox-fa iknox-fa requested a review from a team as a code owner April 11, 2023 14:57
@iknox-fa iknox-fa requested review from mikealfare, stu-k, jtcohen6 and a team and removed request for mikealfare April 11, 2023 14:57
Copy link
Contributor

@stu-k stu-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure this could benefit from a test somewhere, but this implementation looks correct 👍

@iknox-fa
Copy link
Contributor Author

iknox-fa commented Apr 11, 2023

I'm sure this could benefit from a test somewhere, but this implementation looks correct 👍

I was thinking about that, but I'm not sure what I could test that wasn't already handled by the functional tests for every command that uses a manifest-- Other than that, it's just basic passthrough logic.

If you think of a useful thing to test, let me know; I'm certainly not opposed to more testing.

@iknox-fa iknox-fa merged commit 49eed67 into main Apr 11, 2023
@iknox-fa iknox-fa deleted the iknox/CT-1767-GH-6547-parse-should-return-manifest branch April 11, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1767] [Feature] dbt parse should return a manifest
3 participants