Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse command should return manifest when invoked via dbtRunner #7314

Merged
merged 5 commits into from
Apr 11, 2023
+10 −2
Merged

Parse command should return manifest when invoked via dbtRunner #7314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
682ba0e
The simplest possible implementation
iknox-fa Apr 10, 2023
b86971d
changelog
iknox-fa Apr 10, 2023
5a3c6ea
PR feedback
iknox-fa Apr 10, 2023
b212909
Merge branch 'main' into iknox/CT-1767-GH-6547-parse-should-return-ma…
iknox-fa Apr 11, 2023
67ec88d
Updated dbtRunnerResult
iknox-fa Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Under the Hood-20230410-164543.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Under the Hood
body: '`Parse` now returns manifest when invoked via dbtRunner'
time: 2023-04-10T16:45:43.17915-05:00
custom:
Author: iknox-fa
Issue: "6547"
6 changes: 4 additions & 2 deletions core/dbt/cli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ class dbtRunnerResult:
bool, # debug
CatalogArtifact, # docs generate
List[str], # list/ls
None, # clean, deps, init, parse, source
Manifest, # parse
None, # clean, deps, init, source
RunExecutionResult, # build, compile, run, seed, snapshot, test
RunOperationResultsArtifact, # run-operation
] = None
Expand Down Expand Up @@ -533,7 +534,8 @@ def list(ctx, **kwargs):
def parse(ctx, **kwargs):
"""Parses the project and provides information on performance"""
# manifest generation and writing happens in @requires.manifest
return None, True

return ctx.obj["manifest"], True


# dbt run
Expand Down