From 2c7541b9742c6bd2f4e75ecffc0d591bbb547b6b Mon Sep 17 00:00:00 2001 From: Scott Gigante Date: Sat, 13 Jan 2024 18:00:11 +1030 Subject: [PATCH 1/2] Fire skipped events at debug level Closes https://github.com/dbt-labs/dbt-core/issues/8774 --- core/dbt/task/printer.py | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/core/dbt/task/printer.py b/core/dbt/task/printer.py index a05e4089676..6e8ed419375 100644 --- a/core/dbt/task/printer.py +++ b/core/dbt/task/printer.py @@ -5,6 +5,7 @@ ) from dbt.common.events.functions import fire_event from dbt.common.events.types import Formatting +from dbt.events.base_types import EventLevel from dbt.events.types import ( RunResultWarning, RunResultWarningMessage, @@ -75,11 +76,10 @@ def print_run_status_line(results) -> None: def print_run_result_error(result, newline: bool = True, is_warning: bool = False) -> None: - if newline: - with TextOnly(): - fire_event(Formatting("")) - if result.status == NodeStatus.Fail or (is_warning and result.status == NodeStatus.Warn): + if newline: + with TextOnly(): + fire_event(Formatting("")) if is_warning: fire_event( RunResultWarning( @@ -115,7 +115,16 @@ def print_run_result_error(result, newline: bool = True, is_warning: bool = Fals fire_event(Formatting("")) fire_event(CheckNodeTestFailure(relation_name=result.node.relation_name)) + elif result.status == NodeStatus.Skipped and result.message is not None: + if newline: + with TextOnly(): + fire_event(Formatting(""), level=EventLevel.DEBUG) + fire_event(RunResultError(msg=result.message), level=EventLevel.DEBUG) + elif result.message is not None: + if newline: + with TextOnly(): + fire_event(Formatting("")) fire_event(RunResultError(msg=result.message)) From edbd4c54060df1aa085b137d73105904a01102ab Mon Sep 17 00:00:00 2001 From: Scott Gigante Date: Sat, 13 Jan 2024 18:08:06 +1030 Subject: [PATCH 2/2] add changelog entry --- .changes/unreleased/Fixes-20240113-073615.yaml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changes/unreleased/Fixes-20240113-073615.yaml diff --git a/.changes/unreleased/Fixes-20240113-073615.yaml b/.changes/unreleased/Fixes-20240113-073615.yaml new file mode 100644 index 00000000000..3472fa4292d --- /dev/null +++ b/.changes/unreleased/Fixes-20240113-073615.yaml @@ -0,0 +1,6 @@ +kind: Fixes +body: Convert "Skipping model due to fail_fast" message to DEBUG level +time: 2024-01-13T07:36:15.836294-00:00 +custom: + Author: scottgigante + Issue: "8774"