Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base 207/add test #119

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Base 207/add test #119

merged 4 commits into from
Jul 12, 2024

Conversation

VersusFacit
Copy link
Contributor

Followon from Base Adapter #207

Problem

We should be testing for this!

Solution

Add the test.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit self-assigned this Jun 25, 2024
@VersusFacit VersusFacit requested a review from a team as a code owner June 25, 2024 07:10
@cla-bot cla-bot bot added the cla:yes label Jun 25, 2024
@VersusFacit VersusFacit changed the title Add test. Base 207/add test Jun 25, 2024
@VersusFacit VersusFacit force-pushed the ADAP-207/add_base_adapter_show_test branch 8 times, most recently from 7dc63ee to e9fbcc3 Compare June 27, 2024 22:23
@VersusFacit VersusFacit force-pushed the ADAP-207/add_base_adapter_show_test branch from 935e08c to a076761 Compare June 28, 2024 07:02
@VersusFacit VersusFacit merged commit 00df40d into main Jul 12, 2024
21 checks passed
@VersusFacit VersusFacit deleted the ADAP-207/add_base_adapter_show_test branch July 12, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@VersusFacit VersusFacit

Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VersusFacit @colin-rogers-dbt @mikealfare