Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test macos-14 on Python 3.10 instead of Python 3.9 due to missing psycopg2-binary #942

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

psycopg2-binary did not publish a wheel for Python 3.9 on macos-14.

Solution

Test macos-14 against Python 3.10.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Nov 6, 2024
@mikealfare mikealfare self-assigned this Nov 6, 2024
@mikealfare mikealfare requested a review from a team as a code owner November 6, 2024 19:59
@cla-bot cla-bot bot added the cla:yes label Nov 6, 2024
@mikealfare
Copy link
Contributor Author

The failed CI run is expected; that is the issue this PR resolves, but the check runs in the target context (main), so we don't see it working here.

@mikealfare mikealfare enabled auto-merge (squash) November 6, 2024 20:56
@mikealfare mikealfare disabled auto-merge November 6, 2024 21:41
@mikealfare mikealfare merged commit fa4d72c into main Nov 6, 2024
43 of 44 checks passed
@mikealfare mikealfare deleted the skip-macos14-py39 branch November 6, 2024 21:42
mikealfare added a commit that referenced this pull request Nov 8, 2024
mikealfare added a commit that referenced this pull request Nov 8, 2024
mikealfare added a commit that referenced this pull request Nov 8, 2024
mikealfare added a commit that referenced this pull request Nov 8, 2024
* move github runner from macos-12 to macos-14 (#941)

(cherry picked from commit d024eaf)

* test macos-14 on py310 instead of py39 due to missing psycopg2-binary (#942)

(cherry picked from commit fa4d72c)

* matrix entries need to be an array, even with only one value (#943)

(cherry picked from commit 1943ac5)

---------

Co-authored-by: Colin Rogers <111200756+colin-rogers-dbt@users.noreply.github.com>
mikealfare added a commit that referenced this pull request Nov 8, 2024
* move github runner from macos-12 to macos-14 (#941)

(cherry picked from commit d024eaf)

* test macos-14 on py310 instead of py39 due to missing psycopg2-binary (#942)

(cherry picked from commit fa4d72c)

* matrix entries need to be an array, even with only one value (#943)

(cherry picked from commit 1943ac5)

---------

Co-authored-by: Colin Rogers <111200756+colin-rogers-dbt@users.noreply.github.com>
mikealfare added a commit that referenced this pull request Nov 8, 2024
* move github runner from macos-12 to macos-14 (#941)

(cherry picked from commit d024eaf)

* test macos-14 on py310 instead of py39 due to missing psycopg2-binary (#942)

(cherry picked from commit fa4d72c)

* matrix entries need to be an array, even with only one value (#943)

(cherry picked from commit 1943ac5)

---------

Co-authored-by: Colin Rogers <111200756+colin-rogers-dbt@users.noreply.github.com>
mikealfare added a commit that referenced this pull request Nov 8, 2024
* move github runner from macos-12 to macos-14 (#941)

* move github runner from macos-12 to macos-14

(cherry picked from commit d024eaf)

* update test matrix

---------

Co-authored-by: Colin Rogers <111200756+colin-rogers-dbt@users.noreply.github.com>
mikealfare added a commit that referenced this pull request Nov 8, 2024
* move github runner from macos-12 to macos-14 (#941)

* move github runner from macos-12 to macos-14

(cherry picked from commit d024eaf)

* update test matrix

---------

Co-authored-by: Colin Rogers <111200756+colin-rogers-dbt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants