update for generalized constraint warnings #707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmyoop
commented
Apr 10, 2023
| {% if constraint.type != 'not_null' %} | ||
| {{ exceptions.warn('Invalid constraint for column ' ~ column_name ~ '. Only `not_null` is supported.') }} | ||
| {% else %} | ||
| {% if constraint.type == 'not_null' %} |
There was a problem hiding this comment.
Does this make sense? I'm not sure why this is the behavior now if none of the constraints are enforced?
There was a problem hiding this comment.
There's been talk in other PR's of logging warnings that certain constraints aren't enforced.
If you've got those covered upstream, and I think you do, I endorse this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #656
Description
Uses centralized warnings from
dbt-corefor constraints.Checklist
changie newto create a changelog entry