Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pull_request_target trigger for CI #971

Closed
emmyoop opened this issue Dec 6, 2024 · 1 comment · Fixed by #970
Closed

Use pull_request_target trigger for CI #971

emmyoop opened this issue Dec 6, 2024 · 1 comment · Fixed by #970
Labels
bug Something isn't working triage

Comments

@emmyoop
Copy link
Member

emmyoop commented Dec 6, 2024

Describe the bug

PRs from forks will fail CI because the PR trigger is pull_request so they do not have access to the repo vars that are needed since the workflow runs in the context of the fork.

Steps to reproduce

Open a PR from a fork.

Expected results

CI passes

Actual results

CI fails because vars are missing

Additional context

Are you interested in contributing the fix?

yes

@dbeatty10
Copy link
Contributor

@emmyoop Assuming we'll need something similar in dbt-codegen here, dbt-project-evaluator, etc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
2 participants