From 15f9719774dd00b74e79be934f526d048cd774df Mon Sep 17 00:00:00 2001 From: Calvin Giles Date: Thu, 13 Aug 2020 15:33:04 +1200 Subject: [PATCH 1/3] Clarify date_spine behaviour in docs. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 30607d4e..37f3841e 100644 --- a/README.md +++ b/README.md @@ -95,7 +95,7 @@ Usage: --- ### Date/Time #### date_spine ([source](macros/datetime/date_spine.sql)) -This macro returns the sql required to build a date spine. +This macro returns the sql required to build a date spine. The spine as half open, so it will include the start_date (if it is aligned to the `datepart`), but it will not include the `end_date`. Usage: ``` From 4a5206ae4074c7ff0f45c8b8026f169d16eab08a Mon Sep 17 00:00:00 2001 From: Calvin Giles Date: Thu, 13 Aug 2020 15:46:57 +1200 Subject: [PATCH 2/3] Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8648e52b..ee342f17 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,3 +15,4 @@ ## Quality of life * Improve release process, and fix tests (#251) * Make deprecation warnings more useful (#258 @tayloramurphy) +* Add more docs for `date_spine` (#265 @calvingiles) From 8877227075bac62be55b0be1e34661049750f0bd Mon Sep 17 00:00:00 2001 From: Calvin Giles <2253836+calvingiles@users.noreply.github.com> Date: Thu, 24 Sep 2020 04:00:50 +0100 Subject: [PATCH 3/3] Update README.md Co-authored-by: Claire Carroll --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 990037c0..a31cb5a6 100644 --- a/README.md +++ b/README.md @@ -95,7 +95,7 @@ Usage: --- ### Date/Time #### date_spine ([source](macros/datetime/date_spine.sql)) -This macro returns the sql required to build a date spine. The spine as half open, so it will include the start_date (if it is aligned to the `datepart`), but it will not include the `end_date`. +This macro returns the sql required to build a date spine. The spine will include the `start_date` (if it is aligned to the `datepart`), but it will not include the `end_date`. Usage: ```