Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to dbt list command #3138

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Changes to dbt list command #3138

merged 4 commits into from
Apr 6, 2023

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Adding a note to migration guide about dbt list no longer suppressing info logs

Checklist

@matthewshaver matthewshaver requested a review from a team as a code owner April 4, 2023 18:55
@netlify
Copy link

netlify bot commented Apr 4, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit b36e7f6
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/642f47285f137f0008048cc0
😎 Deploy Preview https://deploy-preview-3138--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. labels Apr 4, 2023
@matthewshaver matthewshaver requested a review from jtcohen6 April 4, 2023 19:33
mirnawong1
mirnawong1 reviewed Apr 5, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit @matthewshaver , looks great!

@mirnawong1 @matthewshaver
Update website/docs/guides/migration/versions/02-upgrading-to-v1.5.md
26cf4a0 
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
mirnawong1
mirnawong1 approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you @matthewshaver !

@matthewshaver matthewshaver enabled auto-merge April 6, 2023 22:26
@matthewshaver matthewshaver merged commit 39b4211 into current Apr 6, 2023
@matthewshaver matthewshaver deleted the dbt-list-changes branch April 6, 2023 22:30
@matthewshaver matthewshaver mentioned this pull request Apr 13, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewshaver @mirnawong1