-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for adding columns to snapshots #477
Conversation
@schlich Let me know If I need to do more :) |
Thanks for the PR! Ideally I'd like to see a corresponding test that captures the bug -- The fix makes enough sense to me. Let's try to replicate this failure in a test:
I'm not too familiar with snapshots so if you feel like you're not sure how to implement the test in the code base, let's discuss a high level approach here and figure out how it translates. |
I don't have a full dev environment for this yet so might take a while.
|
@schlich Ref: https://github.com/dbt-labs/dbt-core/tree/main/tests/functional/simple_snapshot |
Adding my two cents. Yes if there is a core test(s) from the default test suite then those should get implemented and overridden as needed. |
Chiming in here: my colleagues and myself recently did a lot of work for dbt-synapse and dbt-fabric (bringing both to dbt 1.8). We also noticed that dbt-fabric does not implement all the tests it should. It has all tests until dbt 1.4 (that's the point until where I implemented all of them and transferred ownership to Microsoft) but all newer ones haven't been added yet. Our assignment focussed solely on dbt-synapse so we implemented them there. You might be able to leverage a lot of the work we did there. |
Thanks for the comments @sdebruyn @cody-scott See the latest commits in which I overwrite some of the snapshot test functions to get it to work well. The main branch did not work as expected: |
Maybe a new issue / enhancement should be raised to solve this. |
@schlich : let me know in case I need to update something |
Fix to be able to add columns in snapshots.
Changes