-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renew lgtx8p.h and lgtx8e.h with Arduino style register definitions. #79
Conversation
Fantastic! |
Not tested yet, but I read back every modification many times carefully. I ask others to help testing this two files. |
Marked as draft, you can mark it as "not draft" when you've smoke tested it and want me to merge. |
By the way, related to register definitions, I use vscode and it is nice to get datasheet bits when you hover a register. |
@dbuezas |
Anyway, I have only one big project, based on LGT, which not using LGT's extra registers of related to timers. So I could test if the new files are free of compiler errors. |
That should be enough for now, worse case scenario some are not fully functional, which was already the case before. |
Tested with this program:
|
Fantastic work @LaZsolt ! |
(*((volatile unsigned char *) address ))
replaced to_SFR_MEM8( address )
or_SFR_IO8( address )
and replacement of the missing 16 bit registers definitions:
_SFR_MEM16( address )
or_SFR_IO16( address )
according to #57 (comment)