From 42b480e7387b88db5d22ab6a0d83c7cc854d3668 Mon Sep 17 00:00:00 2001 From: Matt Traynham Date: Mon, 23 Mar 2015 14:23:35 -0400 Subject: [PATCH 1/2] When not using Crossfilter and coordinate grids, the xDomain length may change. Need to trigger an update to xScale --- src/coordinate-grid-mixin.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/coordinate-grid-mixin.js b/src/coordinate-grid-mixin.js index 658c0d869..c3e06577e 100644 --- a/src/coordinate-grid-mixin.js +++ b/src/coordinate-grid-mixin.js @@ -393,7 +393,8 @@ dc.coordinateGridMixin = function (_chart) { // has the domain changed? var xdom = _x.domain(); - if (!_lastXDomain || xdom.some(function (elem, i) { return elem !== _lastXDomain[i]; })) { + if (!_lastXDomain || _lastXDomain.length !== xdom.length || + xdom.some(function (elem, i) { return elem !== _lastXDomain[i]; })) { _chart.rescale(); } _lastXDomain = xdom; From 77b3fc35ac3bfb8d4fac0fcf7fe7feec463cdbde Mon Sep 17 00:00:00 2001 From: Matt Traynham Date: Thu, 26 Mar 2015 14:54:04 -0400 Subject: [PATCH 2/2] Always update bar sizes on render --- src/coordinate-grid-mixin.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/coordinate-grid-mixin.js b/src/coordinate-grid-mixin.js index c3e06577e..f75a10759 100644 --- a/src/coordinate-grid-mixin.js +++ b/src/coordinate-grid-mixin.js @@ -379,7 +379,7 @@ dc.coordinateGridMixin = function (_chart) { return groups.map(_chart.keyAccessor()); }; - function prepareXAxis(g) { + function prepareXAxis(g, render) { if (!_chart.isOrdinal()) { if (_chart.elasticX()) { _x.domain([_chart.xAxisMin(), _chart.xAxisMax()]); @@ -393,7 +393,7 @@ dc.coordinateGridMixin = function (_chart) { // has the domain changed? var xdom = _x.domain(); - if (!_lastXDomain || _lastXDomain.length !== xdom.length || + if (render || !_lastXDomain || _lastXDomain.length !== xdom.length || xdom.some(function (elem, i) { return elem !== _lastXDomain[i]; })) { _chart.rescale(); } @@ -1001,7 +1001,7 @@ dc.coordinateGridMixin = function (_chart) { _brushOn = false; } - prepareXAxis(_chart.g()); + prepareXAxis(_chart.g(), render); _chart._prepareYAxis(_chart.g()); _chart.plotData();