Skip to content

Conversation

@dcmaddix
Copy link
Owner

@dcmaddix dcmaddix commented Oct 10, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Test Plan

Test Result

(Optional) Documentation Update

Comment on lines +41 to +44
if (adapter_enabled[lora_id] * num_tokens_per_lora[lora_id] == 0) {
return;
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m wondering why we don’t use activate_lora_ids[lora_idx] to check if LoRA is enabled here, and num_tokens_per_lora[lora_id] to determine if there are any tokens that need to be processed by the LoRA. Is there another consideration?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the intention with adapter_enabled is to allow us to skip the moe_lora_align_sum_kernel if the LoRA model does not have MoE adapters (e.g. a LoRA model which only includes adapters for attn projections).

from my understanding, activate_lora_ids and num_tokens_per_lora only indicate if a LoRA model is being invoked, but does not indicate which specific LoRA kernels are applicable for that model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants