Add a custom log formatter #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It just keeps the log entry message and appends a newline to it.
This makes them more user-friendly in the terminal.
Before:
INFO[0000] Log message.
After:
Log message.
https://jira.mesosphere.com/browse/DCOS_OSS-3746
Only dump requests/responses when the logging level is set to debug.
br-lewis
reviewed
Jul 9, 2018
pkg/cmd/dcos.go
Outdated
| @@ -19,7 +19,8 @@ const annotationUsageOptions string = "usage_options" | |||
| func NewDCOSCommand(ctx api.Context) *cobra.Command { | |||
| var verbose int | |||
| cmd := &cobra.Command{ | |||
| Use: "dcos", | |||
| Use: "dcos", | |||
| SilenceUsage: true, | |||
There was a problem hiding this comment.
Doesn't this silence the custom usage info that you defined in a different PR?
There was a problem hiding this comment.
It was silenced on invalid usage sometimes, adding it in the persistentPreRun hook seems better, cf. spf13/cobra#340
There was a problem hiding this comment.
I also re-added the field in the plugin commands, as it was unrealted and I'm not sure if it'd break things on this side.
br-lewis
previously approved these changes
Jul 9, 2018
This causes command help messages to appear everytime an error is triggered.
armandgrillet
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just keeps the log entry message and appends a newline to it. This makes them more user-friendly in the terminal.
Before :
After :
https://jira.mesosphere.com/browse/DCOS_OSS-3746