From c67fd992fd4b81125a7f9746f42b38f21141c63f Mon Sep 17 00:00:00 2001
From: Kiyoon Kim <kiyoon@users.noreply.github.com>
Date: Thu, 17 Oct 2024 18:16:54 +0900
Subject: [PATCH] build: drop usage of .postN

---
 .github/workflows/build_and_release.yml | 4 ++--
 README.md                               | 7 +++++--
 build_python.sh                         | 3 ++-
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/build_and_release.yml b/.github/workflows/build_and_release.yml
index ed98e12..fcb4c5c 100644
--- a/.github/workflows/build_and_release.yml
+++ b/.github/workflows/build_and_release.yml
@@ -7,9 +7,9 @@ on:
         required: true
         default: 3.4.1
       version-tag:
-        description: Python package version to release to PyPI (without 'v')
+        description: Python package version to release to PyPI (without 'v', last digit is the build number)
         required: true
-        default: 3.4.1.post1
+        default: 3.4.1.1
       dry-run:
         description: Dry run
         type: boolean
diff --git a/README.md b/README.md
index 84d193a..f4686c5 100644
--- a/README.md
+++ b/README.md
@@ -43,7 +43,10 @@ Go to Github Actions and run the `Build and Release` workflow.
 
 Version rule:
 
-3.4.1.post2: 3.4.1 is the APBS version, postN can increase with the changes of the package and the builds.
+3.4.1.2:
+
+- 3.4.1 is the APBS version
+- the last digit (.2) is the patch/build number. It increases as we rebuild the wheels with different configurations or update the python API.
 
 
 ### Running locally
@@ -73,7 +76,7 @@ Build four wheels on all platforms. Basically it will put the binaries in the `s
 ```bash
 # first arg: APBS version to find in `data/` (i.e. data/apbs-3.4.1/APBS-3.4.1.Linux)
 # second arg: wheel version
-bash build_python.sh 3.4.1 3.4.1.post2
+bash build_python.sh 3.4.1 3.4.1.2
 ```
 
 Test the wheel
diff --git a/build_python.sh b/build_python.sh
index 02c3952..1188166 100755
--- a/build_python.sh
+++ b/build_python.sh
@@ -1,7 +1,8 @@
 if [ "$#" -ne 2 ]; then
     echo "Build python wheels in a temp directory."
     echo "Usage: $0 <apbs_version> <py_package_version>"
-    echo "Example: $0 3.4.1 3.4.1.post4"
+    echo "Example: $0 3.4.1 3.4.1.4"
+    echo "The python package version should be the same as the APBS version plus a patch (build) version."
     exit 1
 fi