This repository has been archived by the owner on Sep 13, 2024. It is now read-only.
DBZ-7824 Introduce dialect.starrocks.catalog_name config property
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpechane
reviewed
Apr 29, 2024
There was a problem hiding this comment.
@Naros The code is fine for me. Still I'd argue that we should not tie it directly to StarRocks. Can we rename the vars and config property to make it generic override value and only mention in documentation that for StarRocks it is necessary to set the option?
WDYT?
|
I think that's fine @jpechane, I'm still trying to see why StarRocks doesn't work with this but once I get past that, it'll rework the PR accordingly 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/DBZ-7824