Integration #3
Integration #3
Conversation
debopamsengupta
force-pushed
the
integration
branch
from
125431b
to
6415acb
Compare
|
Looks good! Need to find out what's going on with Windows. My assumption is that the require stuff fails due to some path normalisation that is not right for Windows. Another thing to test, not sure it is supported out of the box, is the possibility to require different file trees, such as |
integration/integration.test.js
Outdated
| it('should fetch correct version', () => { | ||
| let requirer = new ry.Requirer(); | ||
| let a = requirer.require('lodash@1.3.1'); | ||
| expect(a.drop).toBeTruthy(); //for 1.x |
There was a problem hiding this comment.
just noticed lodash has a VERSION property available 😂 will update the tests
debopamsengupta
force-pushed
the
integration
branch
from
954bbb5
to
f16e78f
Compare
|
@matteofigus Finally discovered the issue with windows , which is scott113341/npm-install-version#32 Will wait on that to get merged, or would it be better to rewrite the installation/requiring logic in this project ? |
|
Let's see if they reply and merge. If they take too much to reply, probably we can fork or re-implement (it should be not too much code for that). |
Hi @matteofigus ,
I added some integration tests, to ensure full Windows support.
Let me know if you feel anything else might be important :)