Skip to content

Conversation

@diafour
Copy link
Member

@diafour diafour commented Nov 24, 2025

Description

  • Cancel garbage collection if wait for provisioners for more than 2 hours.

Why do we need it, and what problem does it solve?

Provisioners may work at the beginning of garbage collection and controller waits until all provisioners are finished. This wait process should have timeout.

What is the expected result?

GC cancels if provisioners are not finished, condition is set.

Checked with 2m timeout:

{
  "lastTransitionTime": "2025-11-24T17:42:52Z",
  "lastUpdateTime": "2025-11-24T17:42:52Z",
  "message": "Wait for resources provisioners more than 2m0s timeout: 2m1.022922825s elapsed, garbage collection canceled",
  "reason": "Error",
  "status": "False",
  "type": "GarbageCollection"
}

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: module
type: chore
summary: Cancel dvcr garbage collection if wait for provisioners for more than 2 hours.

@diafour diafour added this to the v1.2.0 milestone Nov 24, 2025
@diafour diafour marked this pull request as draft November 24, 2025 14:36
@diafour diafour marked this pull request as ready for review November 25, 2025 11:28
@diafour diafour force-pushed the chore/module/dvcr-gc-wait-importers-timeout branch from d1cf5df to dfcfd25 Compare November 25, 2025 11:44
@Isteb4k Isteb4k modified the milestones: v1.2.0, v1.3.0 Nov 26, 2025
- Cancel garbage collection if wait for provisioners more than 2 hours.

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour diafour force-pushed the chore/module/dvcr-gc-wait-importers-timeout branch from dfcfd25 to ddf1ee6 Compare December 1, 2025 10:36
@diafour diafour merged commit f5ee46f into main Dec 1, 2025
27 of 28 checks passed
@diafour diafour deleted the chore/module/dvcr-gc-wait-importers-timeout branch December 1, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants