From 5ded975137efd26ae32d482d7d853a34886c7802 Mon Sep 17 00:00:00 2001
From: Philemon Ukane <ukanephilemon@gmail.com>
Date: Fri, 5 Jan 2024 13:50:35 +0100
Subject: [PATCH] dcrpg:remove duplicates for votes, misses and treasury table

Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
---
 db/dcrpg/indexing.go            | 12 +++++++++++
 db/dcrpg/internal/stakestmts.go | 29 ++++++++++++++++++++++++++
 db/dcrpg/queries.go             | 36 +++++++++++++++++++++++++++++++++
 db/dcrpg/tables.go              |  9 +++++++++
 4 files changed, 86 insertions(+)

diff --git a/db/dcrpg/indexing.go b/db/dcrpg/indexing.go
index b36571279..3ea2c6429 100644
--- a/db/dcrpg/indexing.go
+++ b/db/dcrpg/indexing.go
@@ -394,6 +394,18 @@ func (pgb *ChainDB) DeleteDuplicateAgendaVotes() (int64, error) {
 	return DeleteDuplicateAgendaVotes(pgb.db)
 }
 
+func (pgb *ChainDB) DeleteDuplicateVotes() (int64, error) {
+	return DeleteDuplicateVotes(pgb.db)
+}
+
+func (pgb *ChainDB) DeleteDuplicateMisses() (int64, error) {
+	return DeleteDuplicateMisses(pgb.db)
+}
+
+func (pgb *ChainDB) DeleteDuplicateTreasuryTxs() (int64, error) {
+	return DeleteDuplicateTreasuryTxs(pgb.db)
+}
+
 // Indexes checks
 
 // MissingIndexes lists missing table indexes and their descriptions.
diff --git a/db/dcrpg/internal/stakestmts.go b/db/dcrpg/internal/stakestmts.go
index fa7d00ebd..9816fa1f2 100644
--- a/db/dcrpg/internal/stakestmts.go
+++ b/db/dcrpg/internal/stakestmts.go
@@ -410,6 +410,35 @@ const (
 				FROM agenda_votes) t
 			WHERE t.rnum > 1);`
 
+	// DeleteVotesDuplicateRows removes rows that would violate the unique
+	// index uix_votes_hashes_index. This should be run prior to creating the index.
+	DeleteVotesDuplicateRows = `DELETE FROM votes
+	WHERE id IN (SELECT id FROM (
+			SELECT id,
+				row_number() OVER (PARTITION BY tx_hash, block_hash ORDER BY id DESC) AS rnum
+			FROM votes) t
+		WHERE t.rnum > 1);`
+
+	// DeleteMissesDuplicateRows removes rows that would violate the unique
+	// index uix_misses_hashes_index. This should be run prior to creating the index.
+	DeleteMissesDuplicateRows = `DELETE FROM misses
+	WHERE id IN (SELECT id FROM (
+			SELECT id,
+				row_number() OVER (PARTITION BY ticket_hash, block_hash ORDER BY id DESC) AS rnum
+			FROM misses) t
+		WHERE t.rnum > 1);`
+
+	// DeleteTreasuryTxsDuplicateRows removes rows that would violate the unique
+	// index uix_treasury_tx_hash. This should be run prior to creating the index.
+	DeleteTreasuryTxsDuplicateRows = `DELETE FROM treasury
+	WHERE (tx_hash, block_hash) IN (SELECT tx_hash, block_hash FROM (
+			SELECT 
+			tx_hash,
+			block_hash,
+				row_number() OVER (PARTITION BY tx_hash, block_hash) AS rnum
+			FROM treasury) t
+		WHERE t.rnum > 1);`
+
 	// Select
 
 	SelectAgendasVotesByTime = `SELECT votes.block_time AS timestamp,` +
diff --git a/db/dcrpg/queries.go b/db/dcrpg/queries.go
index d06cf1f22..7174c9c3b 100644
--- a/db/dcrpg/queries.go
+++ b/db/dcrpg/queries.go
@@ -270,6 +270,42 @@ func DeleteDuplicateAgendaVotes(db *sql.DB) (int64, error) {
 	return sqlExec(db, internal.DeleteAgendaVotesDuplicateRows, execErrPrefix)
 }
 
+// DeleteDuplicateVotes deletes rows in votes with duplicate tx_hash and
+// block_hash leaving one row with the lowest id.
+func DeleteDuplicateVotes(db *sql.DB) (int64, error) {
+	if isuniq, err := IsUniqueIndex(db, internal.IndexOfVotesTableOnHashes); err != nil && err != sql.ErrNoRows {
+		return 0, err
+	} else if isuniq {
+		return 0, nil
+	}
+	execErrPrefix := "failed to delete duplicate votes: "
+	return sqlExec(db, internal.DeleteVotesDuplicateRows, execErrPrefix)
+}
+
+// DeleteDuplicateMisses deletes rows in misses with duplicate ticket_hash and
+// block_hash leaving one row with the lowest id.
+func DeleteDuplicateMisses(db *sql.DB) (int64, error) {
+	if isuniq, err := IsUniqueIndex(db, internal.IndexOfMissesTableOnHashes); err != nil && err != sql.ErrNoRows {
+		return 0, err
+	} else if isuniq {
+		return 0, nil
+	}
+	execErrPrefix := "failed to delete duplicate misses: "
+	return sqlExec(db, internal.DeleteMissesDuplicateRows, execErrPrefix)
+}
+
+// DeleteDuplicateTreasuryTxs deletes rows in misses with duplicate tx_hash and
+// block_hash leaving one row with the lowest id.
+func DeleteDuplicateTreasuryTxs(db *sql.DB) (int64, error) {
+	if isuniq, err := IsUniqueIndex(db, internal.IndexOfTreasuryTableOnTxHash); err != nil && err != sql.ErrNoRows {
+		return 0, err
+	} else if isuniq {
+		return 0, nil
+	}
+	execErrPrefix := "failed to delete duplicate treasury txs: "
+	return sqlExec(db, internal.DeleteTreasuryTxsDuplicateRows, execErrPrefix)
+}
+
 // --- stake (votes, tickets, misses, treasury) tables ---
 
 func InsertTreasuryTxns(db *sql.DB, dbTxns []*dbtypes.Tx, checked, updateExistingRecords bool) error {
diff --git a/db/dcrpg/tables.go b/db/dcrpg/tables.go
index 78e7a6015..b7e7270fc 100644
--- a/db/dcrpg/tables.go
+++ b/db/dcrpg/tables.go
@@ -214,6 +214,15 @@ func (pgb *ChainDB) DeleteDuplicates(barLoad chan *dbtypes.ProgressBarLoad) erro
 
 		// Remove duplicate agenda_votes
 		{TableName: "agenda_votes", DropDupsFunc: pgb.DeleteDuplicateAgendaVotes},
+
+		// Remove duplicate votes
+		{TableName: "votes", DropDupsFunc: pgb.DeleteDuplicateVotes},
+
+		// Remove duplicate misses
+		{TableName: "misses", DropDupsFunc: pgb.DeleteDuplicateMisses},
+
+		// Remove duplicate treasury txs
+		{TableName: "treasury", DropDupsFunc: pgb.DeleteDuplicateTreasuryTxs},
 	}
 
 	var err error