Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/multi file inference #96

Merged
merged 18 commits into from
Sep 17, 2024
Merged

Feature/multi file inference #96

merged 18 commits into from
Sep 17, 2024

Conversation

mosheman5
Copy link
Collaborator

Now we can:

  • perform inference either on a single file or multiple files
  • we get multiple classes merged to one raven file in case we have classification model
  • a script to merge multiple raven files to a single big raven file

@mosheman5 mosheman5 added the ci-test label to trigger CI flow label Jul 3, 2024
@mosheman5
Merge branch 'master' into feature/multi-file-inference
79c8322 
# Conflicts:
#	soundbay/inference.py
shaing10
shaing10 approved these changes Jul 7, 2024
View reviewed changes
Copy link
Collaborator

@shaing10 shaing10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it can make our lives much easier :)

scripts/merge_multiple_ravens_to_one_file.py
# get the list of audio files
audio_files = list(audio_folder.glob('*.wav'))
# sort the audio files by name, should be the order by start time as well
audio_files = sorted(audio_files)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be nice to allow the user to define the key to sort by (sort by name can be the default)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not gonna implement it now, if needed in the future we can have a user defined key ordering

scripts/merge_multiple_ravens_to_one_file.py Show resolved Hide resolved
soundbay/results_analysis.py Outdated
""" Converts a csv file containing the inference results to a raven csv file.
Args: probsdataframe: a pandas dataframe containing the inference results.
Args: probsdataframe: a pandas dataframe cosntaining the inference results.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

soundbay/results_analysis.py Show resolved Hide resolved
soundbay/results_analysis.py Show resolved Hide resolved
@mosheman5 mosheman5 added ci-test label to trigger CI flow and removed ci-test label to trigger CI flow labels Sep 17, 2024
@mosheman5 mosheman5 added ci-test label to trigger CI flow and removed ci-test label to trigger CI flow labels Sep 17, 2024
@mosheman5 mosheman5 merged commit df28f94 into master Sep 17, 2024
2 checks passed
@mosheman5 mosheman5 deleted the feature/multi-file-inference branch September 17, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaing10 shaing10 shaing10 approved these changes

@Z30G0D Z30G0D Awaiting requested review from Z30G0D

@amitgalor18 amitgalor18 Awaiting requested review from amitgalor18

Assignees
No one assigned
Labels
ci-test label to trigger CI flow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mosheman5 @shaing10