diff --git a/test/nanostack/unittest/thread/nvm/test_thread_nvm_store.c b/test/nanostack/unittest/thread/nvm/test_thread_nvm_store.c index d6a32db2ee8..633b91b3a3e 100644 --- a/test/nanostack/unittest/thread/nvm/test_thread_nvm_store.c +++ b/test/nanostack/unittest/thread/nvm/test_thread_nvm_store.c @@ -318,6 +318,8 @@ bool test_thread_nvm_store_device_data() ns_file_system_set_root_path(ROOT_FILE_PATH); uint8_t mac[8]; uint8_t mle_id[8]; + memset(mle_id, 0, 8); + memset(mac, 0, 8); mac[0] = 7; mac[7] = 17; mle_id[0] = 2; @@ -329,6 +331,8 @@ bool test_thread_nvm_store_device_data() uint8_t mac_read[8]; uint8_t mle_id_read[8]; + memset(mac_read, 0, 8); + memset(mle_id_read, 0, 8); ret = thread_nvm_store_device_configuration_read(mac_read, mle_id_read); ns_file_system_set_root_path(NULL); diff --git a/test/nanostack/unittest/thread/thread_commissioning_api/test_thread_commissioning_api.c b/test/nanostack/unittest/thread/thread_commissioning_api/test_thread_commissioning_api.c index 5da9c719bd5..186987942e9 100644 --- a/test/nanostack/unittest/thread/thread_commissioning_api/test_thread_commissioning_api.c +++ b/test/nanostack/unittest/thread/thread_commissioning_api/test_thread_commissioning_api.c @@ -137,15 +137,19 @@ bool test_thread_commissioning_petition_start() { int8_t interface_id = 6; int status_cb_ptr = 1; - char commissioner_id_ptr[1]; + + char commissioner_id_ptr[2]; + memset(commissioner_id_ptr, 0, 2); commissioner_id_ptr[0] = 'a'; - char commissioner_id_ptr_long[65]; + char commissioner_id_ptr_long[66]; + memset(commissioner_id_ptr_long, 0, 66); if ( -1 != thread_commissioning_petition_start(interface_id,commissioner_id_ptr, &status_cb_ptr)) return false; nsdynmemlib_stub.returnCounter = 1; /*now register a commissioner */ uint8_t pw[16]; + memset(pw, 0, 16); if( 0 != thread_commissioning_register(interface_id, pw) ) return false; if ( -2 != thread_commissioning_petition_start(interface_id,NULL,&status_cb_ptr)) @@ -184,17 +188,21 @@ bool test_thread_commissioning_rx_receive_cb() int status_cb_ptr = 1; - char commissioner_id_ptr[1]; + char commissioner_id_ptr[2]; + commissioner_id_ptr[1] = 0; commissioner_id_ptr[0] = 'a'; uint8_t data_ptr[3]; + memset(data_ptr, 0, 3); int8_t service_id = 0; uint8_t source_address[] = {0xfe,0x80,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xf,0xff}; uint16_t source_port = 1; uint8_t payload[] = {0x11,0x12,0x13,0x16,0x01}; sn_coap_hdr_s response_ptr; + memset(&response_ptr, 0, sizeof(sn_coap_hdr_s)); response_ptr.payload_ptr = payload; response_ptr.payload_len = 5; sn_coap_hdr_s request_ptr; + memset(&request_ptr, 0, sizeof(sn_coap_hdr_s)); request_ptr.payload_ptr = payload; request_ptr.payload_len = 5; nsdynmemlib_stub.returnCounter = 4; @@ -259,17 +267,21 @@ bool test_thread_commissioning_application_provision_cb() int status_cb_ptr = 1; - char commissioner_id_ptr[1]; + char commissioner_id_ptr[2]; + commissioner_id_ptr[1] = 0; commissioner_id_ptr[0] = 'a'; uint8_t data_ptr[3]; + memset(data_ptr, 0, 3); int8_t service_id = 0; uint8_t source_address[] = {0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff}; uint16_t source_port = 1; uint8_t payload[] = {0x11,0x12,0x13,0x16,0x01}; sn_coap_hdr_s response_ptr; + memset(&response_ptr, 0, sizeof(sn_coap_hdr_s)); response_ptr.payload_ptr = payload; response_ptr.payload_len = 5; sn_coap_hdr_s request_ptr; + memset(&request_ptr, 0, sizeof(sn_coap_hdr_s)); request_ptr.payload_ptr = payload; request_ptr.payload_len = 5; nsdynmemlib_stub.returnCounter = 4; @@ -335,17 +347,21 @@ bool test_thread_commissioning_finalisation_req_recv_cb() int status_cb_ptr = 1; - char commissioner_id_ptr[1]; + char commissioner_id_ptr[2]; + commissioner_id_ptr[1] = 0; commissioner_id_ptr[0] = 'a'; uint8_t data_ptr[3]; + memset(data_ptr, 0, 3); int8_t service_id = 0; uint8_t source_address[] = {0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff}; uint16_t source_port = 1; uint8_t payload[] = {0x11,0x12,0x13,0x16,0x01}; sn_coap_hdr_s response_ptr; + memset(&response_ptr, 0, sizeof(sn_coap_hdr_s)); response_ptr.payload_ptr = payload; response_ptr.payload_len = 5; sn_coap_hdr_s request_ptr; + memset(&request_ptr, 0, sizeof(sn_coap_hdr_s)); request_ptr.payload_ptr = payload; request_ptr.payload_len = 5; nsdynmemlib_stub.returnCounter = 4; @@ -396,13 +412,15 @@ bool test_thread_commissioning_petition_keep_alive() int8_t interface_id = 7; commissioning_state_e state = COMMISSIONING_STATE_ACCEPT; - char commissioner_id_ptr[1]; + char commissioner_id_ptr[2]; int status_cb_ptr = 1; + commissioner_id_ptr[1] = 0; commissioner_id_ptr[0] = 'a'; if (-1 != thread_commissioning_petition_keep_alive(interface_id, state)) return false; nsdynmemlib_stub.returnCounter = 1; uint8_t pw[16]; + memset(pw, 0, 16); /*now register a commissioner */ if( 0 != thread_commissioning_register(interface_id, pw) ) return false; @@ -427,6 +445,7 @@ bool test_thread_commissioning_get_management_id() nsdynmemlib_stub.returnCounter = 1; uint8_t pw[16]; + memset(pw, 0, 16); /*now register a commissioner */ if( 0 != thread_commissioning_register(interface_id, pw) ) return false; @@ -444,7 +463,9 @@ bool test_thread_commissioning_native_commissioner_start() { int8_t interface_id = 1; protocol_interface_info_entry_t cur; + memset(&cur, 0, sizeof(protocol_interface_info_entry_t)); thread_info_t thread_info; + memset(&thread_info, 0, sizeof(thread_info_t)); thread_info.version = 1; cur.id = interface_id; cur.thread_info = NULL; @@ -464,14 +485,17 @@ bool test_thread_commissioning_native_commissioner_start() bool test_thread_commissioning_native_commissioner_connect() { thread_commissioning_link_configuration_s link_configuration; + memset(&link_configuration, 0, sizeof(thread_commissioning_link_configuration_s)); int8_t interface_id = 1; protocol_interface_info_entry_t cur; + memset(&cur, 0, sizeof(protocol_interface_info_entry_t)); thread_info_t thread_info; + memset(&thread_info, 0, sizeof(thread_info_t)); thread_info.version = 1; thread_info.thread_attached_state = THREAD_STATE_CONNECTED; thread_info.native_commissioner_port = 10; uint8_t address_ptr; - uint16_t port; + uint16_t port = 1; cur.id = interface_id; cur.thread_info = NULL; protocol_core_stub.entry_ptr = NULL;