From 366826cb35be236b45fb14250a8da5a9084d4dc7 Mon Sep 17 00:00:00 2001 From: Jonathan Liberman Date: Thu, 28 Nov 2024 16:28:07 +0200 Subject: [PATCH] Jonatan/mon 2641 remove launchdarkly (#384) --- backend/deepchecks_monitoring/ee/features_control_cloud.py | 2 +- backend/deepchecks_monitoring/features_control.py | 1 + backend/deepchecks_monitoring/logic/data_ingestion.py | 3 --- backend/tests/conftest.py | 4 ++++ 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/backend/deepchecks_monitoring/ee/features_control_cloud.py b/backend/deepchecks_monitoring/ee/features_control_cloud.py index db2a03ee..982bddc7 100644 --- a/backend/deepchecks_monitoring/ee/features_control_cloud.py +++ b/backend/deepchecks_monitoring/ee/features_control_cloud.py @@ -32,7 +32,7 @@ def model_assignment(self) -> bool: @property def signup_enabled(self) -> bool: - return True + return False @property def onboarding_enabled(self) -> bool: diff --git a/backend/deepchecks_monitoring/features_control.py b/backend/deepchecks_monitoring/features_control.py index 5aa43230..9940c51b 100644 --- a/backend/deepchecks_monitoring/features_control.py +++ b/backend/deepchecks_monitoring/features_control.py @@ -16,6 +16,7 @@ class FeaturesSchema(BaseModel): """Schema to be returned to the client for the features control.""" + signup_enabled: bool slack_enabled: bool rows_per_minute: int onboarding_enabled: bool diff --git a/backend/deepchecks_monitoring/logic/data_ingestion.py b/backend/deepchecks_monitoring/logic/data_ingestion.py index a49098f0..e28fc71f 100644 --- a/backend/deepchecks_monitoring/logic/data_ingestion.py +++ b/backend/deepchecks_monitoring/logic/data_ingestion.py @@ -12,7 +12,6 @@ import asyncio import copy import json -import logging import typing as t import asyncpg.exceptions @@ -346,8 +345,6 @@ def __init__( self.resources_provider: ResourcesProvider = resources_provider self.logger = logger or configure_logger(name="data-ingestion") self.use_kafka = self.resources_provider.kafka_settings.kafka_host is not None - if self.use_kafka: - logging.getLogger("aiokafka.cluster").setLevel(logging.DEBUG) async def _send_with_retry( self, diff --git a/backend/tests/conftest.py b/backend/tests/conftest.py index d180a54a..39b5312b 100644 --- a/backend/tests/conftest.py +++ b/backend/tests/conftest.py @@ -191,6 +191,10 @@ def features_control_mock(settings): class TestsFeaturesControl(CloudFeaturesControl): """Mocked features control class for tests, replacing launchdarkly usage.""" + @property + def signup_enabled(self) -> bool: + return True + @property def rows_per_minute(self) -> int: """Maximum number of rows per minute allowed for organization."""