diff --git a/packages/code-studio/src/styleguide/SpectrumComponents.tsx b/packages/code-studio/src/styleguide/SpectrumComponents.tsx index fb6fb23c6f..b2d9967c2d 100644 --- a/packages/code-studio/src/styleguide/SpectrumComponents.tsx +++ b/packages/code-studio/src/styleguide/SpectrumComponents.tsx @@ -31,7 +31,7 @@ import { Well, } from '@adobe/react-spectrum'; import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; -import { dh } from '@deephaven/icons'; +import { dhTruck, vsEmptyWindow } from '@deephaven/icons'; import { SPECTRUM_COMPONENT_SAMPLES_ID } from './constants'; import { sampleSectionIdAndClassesSpectrum } from './utils'; @@ -75,78 +75,86 @@ export default SpectrumComponents; function ButtonsSample(): JSX.Element { return ( - - - - - - - - - + <> + + + + + Icon Button + + + + + + + + + + - - - - - - - - + + + + + + + + - - Normal - - Quiet - - Static Black - Static White - Disabled + + Normal + + Quiet + + Static Black + Static White + Disabled - - Normal - Quiet - - Emphasized - - Static Black - Static White - Disabled - + + Normal + Quiet + + Emphasized + + Static Black + Static White + Disabled + + ); } @@ -188,7 +196,7 @@ function IllustratedMessageSample(): JSX.Element { return ( - + Illustrated Message This is the content of the message. diff --git a/packages/components/scss/BaseStyleSheet.scss b/packages/components/scss/BaseStyleSheet.scss index aef83108ef..3ee542f3a0 100644 --- a/packages/components/scss/BaseStyleSheet.scss +++ b/packages/components/scss/BaseStyleSheet.scss @@ -3,6 +3,11 @@ @import './custom.scss'; @import 'bootstrap/scss/bootstrap'; +:root { + --dh-svg-inline-icon-size: 16px; + --scrollbar-color: 255, 255, 255; +} + //Various non-variable css overides //Overide default size from 16px to 14px. We need density. html { @@ -14,7 +19,7 @@ html { // and look best at that size. Default icon size back to 16px // vertical alignment changed to best match icon set against 14px text .svg-inline--fa { - font-size: 16px; + font-size: var(--dh-svg-inline-icon-size); vertical-align: -3px; } @@ -656,12 +661,6 @@ input[type='number']::-webkit-inner-spin-button { background: rgba(var(--scrollbar-color), 0.35); } -/* stylelint-disable no-descending-specificity */ -:root { - --scrollbar-color: 255, 255, 255; -} -/* stylelint-enable no-descending-specificity */ - // used in inverted color sections, like light modals .theme-bg-light { --scrollbar-color: 0, 0, 0; diff --git a/packages/components/src/__snapshots__/SpectrumUtils.test.ts.snap b/packages/components/src/__snapshots__/SpectrumUtils.test.ts.snap index 738e8e4ced..849a02d724 100644 --- a/packages/components/src/__snapshots__/SpectrumUtils.test.ts.snap +++ b/packages/components/src/__snapshots__/SpectrumUtils.test.ts.snap @@ -5,7 +5,6 @@ exports[`themeDHDefault should merge Spectrum default with DH custom styles 1`] "dark": { "spectrum--darkest": "spectrum--darkest_256eeb", "theme-spectrum-alias": "theme-spectrum-alias", - "theme-spectrum-overrides": "theme-spectrum-overrides", "theme-spectrum-palette": "theme-spectrum-palette", }, "global": { @@ -23,7 +22,6 @@ exports[`themeDHDefault should merge Spectrum default with DH custom styles 1`] "light": { "spectrum--light": "spectrum--light_a40724", "theme-spectrum-alias": "theme-spectrum-alias", - "theme-spectrum-overrides": "theme-spectrum-overrides", "theme-spectrum-palette": "theme-spectrum-palette", }, "medium": { diff --git a/packages/components/src/theme/__snapshots__/ThemeProvider.test.tsx.snap b/packages/components/src/theme/__snapshots__/ThemeProvider.test.tsx.snap index 08b0d193d9..bd68d2ab79 100644 --- a/packages/components/src/theme/__snapshots__/ThemeProvider.test.tsx.snap +++ b/packages/components/src/theme/__snapshots__/ThemeProvider.test.tsx.snap @@ -9,7 +9,7 @@ exports[`ThemeProvider setSelectedThemeKey: [ [Object] ] should change selected ./theme-light-palette.css?raw