Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert base redux package to typescript #274

Closed
mattrunyon opened this issue Nov 2, 2021 · 0 comments · Fixed by #276
Closed

Convert base redux package to typescript #274

mattrunyon opened this issue Nov 2, 2021 · 0 comments · Fixed by #276
Assignees
Labels
enhancement New feature or request typescript

Comments

@mattrunyon
Copy link
Collaborator

Helpful for #176. Since shortcuts are already in TS, it seems counterproductive to create typings for redux JS files instead of just swapping redux to TS for selectors.

Selectors are still imported from the package which creates them (redux, dashboard-plugins, or code-studio) and thus each package which creates selectors should only need to worry about the store elements it creates.

@mattrunyon mattrunyon added enhancement New feature or request typescript labels Nov 2, 2021
@mattrunyon mattrunyon self-assigned this Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request typescript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant