Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text truncation at very narrow widths #278

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Fix text truncation at very narrow widths #278

merged 2 commits into from
Nov 10, 2021

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Nov 8, 2021

  • Fixed binary search loop - was checking hi > lo instead of hi >= lo
  • Add a check to handle case where the text never fits
  • Set lo to be lower just in case our estimate wasn't low enough
  • Return empty string instead of null for consistent return type
  • Fix mock iris grid to send an update (styleguide just kept showing the spinner since it was waiting for an update event)

@mofojed
Fix text truncation at very narrow widths
51dbbdb 
- Fixed binary search loop - was checking `hi > lo` instead of `hi >= lo`
- Add a check to handle case where the text never fits
- Set lo to be lower just in case our estimate wasn't low enough
@mofojed mofojed added this to the November 2021 milestone Nov 8, 2021
@mofojed mofojed requested a review from spasovski November 8, 2021 21:59
@mofojed mofojed self-assigned this Nov 8, 2021
spasovski
spasovski previously approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@spasovski spasovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The magic number is a nitpick - it's fine to merge without it.

packages/grid/src/GridRenderer.js Show resolved Hide resolved
packages/grid/src/GridRenderer.js Show resolved Hide resolved
@mofojed mofojed added the bug Something isn't working label Nov 9, 2021
@mofojed mofojed requested a review from spasovski November 9, 2021 22:01
@mofojed mofojed merged commit 9925747 into deephaven:main Nov 10, 2021
@mofojed mofojed deleted the 267-text-overlap branch November 10, 2021 13:36
@dsmmcken dsmmcken linked an issue Nov 10, 2021 that may be closed by this pull request
dragging column separator to decrease column size formatting issue #267
Closed
@dsmmcken dsmmcken mentioned this pull request Nov 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spasovski spasovski spasovski approved these changes

Assignees

@mofojed mofojed

Labels
bug Something isn't working web-client-ui
Projects
None yet
Milestone
November 2021
Development

Successfully merging this pull request may close these issues.

dragging column separator to decrease column size formatting issue
2 participants
@mofojed @spasovski