Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-calc lastTop #311

Closed
wants to merge 1 commit into from
Closed

re-calc lastTop #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/grid/src/GridMetricCalculator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,8 @@ class GridMetricCalculator {
null,
width - gridX - scrollBarSize - rowFooterWidth
);
const lastTop = this.getLastTop(

let lastTop = this.getLastTop(
state,
null,
height - gridY - scrollBarSize - floatingBottomHeight
Expand All @@ -225,6 +226,8 @@ class GridMetricCalculator {
barWidth - 1
)
: 0;

// Vertical scrollbar handle height.
const handleHeight =
lastTop > 0
? Math.min(
Expand Down Expand Up @@ -271,6 +274,12 @@ class GridMetricCalculator {
]);
}

lastTop = this.getLastTop(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm why does this need to be re-calculated?

state,
null,
height - gridY - scrollBarSize - floatingBottomHeight
);

let floatingColumns = [];
if (floatingLeftColumnCount > 0 || floatingRightColumnCount > 0) {
floatingColumns = [
Expand Down