Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable codecov support #312

Merged
merged 4 commits into from
Dec 3, 2021
Merged

Enable codecov support #312

merged 4 commits into from
Dec 3, 2021

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Nov 24, 2021

  • Create codecov.yml, with the carryforward flag for partial reports. Already uploaded the initial full report from current main
  • Add badge to readme
  • Enable only on pull requests

@mofojed mofojed added this to the November 2021 milestone Nov 24, 2021
@mofojed mofojed self-assigned this Nov 24, 2021
@mattrunyon
Copy link
Collaborator

Will this fail ever for coverage that is too low? And are you planning to set it up w/ a bot comment/link for the report? Just the report might be fine so we can see changes and determine if we should be adding tests

They'll be set in codecov if necessary
@mofojed
Copy link
Member Author

mofojed commented Nov 24, 2021

Yeah I forgot to remove the coverageThresholds, they're removed now.

I've requested to install the GitHub app which will supposedly comment as codecov, need authorization from Devin first to enable it. Then it should comment automatically on all PRs, with links back to things.

@mofojed
Copy link
Member Author

mofojed commented Nov 25, 2021

Here's an example of a report on my repo: mofojed#1

Once authorized here it should post on here as codecov-commenter. I think the carry forward flag will work correctly once the codecov.yml is merged into main. We'll need to make sure that works.

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #312 (755ddeb) into main (1a9f7fb) will decrease coverage by 39.67%.
The diff coverage is n/a.

❗ Current head 755ddeb differs from pull request most recent head db43a23. Consider uploading reports for the commit db43a23 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             main   #312       +/-   ##
=========================================
- Coverage   39.67%      0   -39.68%     
=========================================
  Files         328      0      -328     
  Lines       23250      0    -23250     
  Branches     4790      0     -4790     
=========================================
- Hits         9224      0     -9224     
+ Misses      13573      0    -13573     
+ Partials      453      0      -453     
Flag Coverage Δ
unit ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/chart/src/ChartModel.js
packages/file-explorer/src/FileStorage.ts
packages/components/src/DraggableItemList.tsx
packages/components/src/ButtonGroup.tsx
...ode-studio/src/styleguide/SelectValueListInput.jsx
packages/chart/src/plotly/Plot.js
packages/iris-grid/src/IrisGridModelFactory.js
packages/components/src/TimeInput.tsx
packages/components/src/RadioGroup.tsx
packages/console/src/monaco/lang/python.js
... and 318 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a9f7fb...db43a23. Read the comment docs.

@mofojed mofojed merged commit beffde3 into deephaven:main Dec 3, 2021
@mofojed mofojed deleted the codecov branch December 3, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants