DH-11788: Enable count aggregations for non-rollups #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #331 +/- ##
===========================================
- Coverage 39.67% 25.30% -14.37%
===========================================
Files 328 2 -326
Lines 23250 735 -22515
Branches 4790 329 -4461
===========================================
- Hits 9224 186 -9038
+ Misses 13573 468 -13105
+ Partials 453 81 -372
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
mofojed
approved these changes
Dec 7, 2021
mofojed
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Count now works as an aggregation for non-rollups. There are no longer any that are rollup exclusively. Leaving code to allow it in future in case any new rollup only aggregation method gets added.