-
Notifications
You must be signed in to change notification settings - Fork 2.5k
style: fix admonition headings #10000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
||
| :::info | ||
| Serialization formats | ||
| :::info Serialization formats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed in most other cases in the document store mdx that you converted :::info into :::note. Although I can't see any difference between those two in the preview. Is there one we should be using or does it not matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great question @sjrl, essentially the idea is that these three categories have distinct meanings:
:::note - Key details that are important for users to understand (essential information)
:::tip - Optional advice or suggestions that can enhance experience but aren't mandatory
:::info - Useful information that adds value but isn't critical
And your comment made me start looking at concrete examples and finding out discrepancies :) I'll add another commit to standardize the admonition type usage!
sjrl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One small question about note vs info
Proposed Changes:
OLD:
OLD:


NEW:
How did you test it?
Builds without errors
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.