Skip to content

Conversation

@dfokina
Copy link
Contributor

@dfokina dfokina commented Oct 31, 2025

Proposed Changes:

  • Fixing admonitions (callouts) to have properly worded headings instead of admonition type, for versions 2.19 and 2.20
  • Some examples:
    OLD:
Screenshot 2025-10-31 at 20 03 42 NEW: Screenshot 2025-10-31 at 20 03 47 ------------------------------------------------------------------------------------------------------------------------

OLD:
Screenshot 2025-10-31 at 20 04 16
NEW:
Screenshot 2025-10-31 at 20 04 11

How did you test it?

Builds without errors

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@dfokina dfokina requested a review from a team as a code owner October 31, 2025 19:44
@dfokina dfokina requested review from vblagoje and removed request for a team October 31, 2025 19:44
@dfokina dfokina added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Oct 31, 2025
@vercel
Copy link

vercel bot commented Oct 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
haystack-docs Ready Ready Preview Comment Nov 3, 2025 2:49pm

@dfokina dfokina changed the title docs: fix admonition headings style: fix admonition headings Nov 3, 2025

:::info
Serialization formats
:::info Serialization formats
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed in most other cases in the document store mdx that you converted :::info into :::note. Although I can't see any difference between those two in the preview. Is there one we should be using or does it not matter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great question @sjrl, essentially the idea is that these three categories have distinct meanings:
:::note - Key details that are important for users to understand (essential information)
:::tip - Optional advice or suggestions that can enhance experience but aren't mandatory
:::info - Useful information that adds value but isn't critical
And your comment made me start looking at concrete examples and finding out discrepancies :) I'll add another commit to standardize the admonition type usage!

Copy link
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One small question about note vs info

@dfokina dfokina enabled auto-merge (squash) November 3, 2025 14:48
@dfokina dfokina merged commit f6907ba into main Nov 3, 2025
10 of 11 checks passed
@dfokina dfokina deleted the admonition-headings branch November 3, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants