Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update release please extra-files to be explicit #26

Merged
merged 1 commit into from
Nov 9, 2023
Merged

chore: update release please extra-files to be explicit #26

merged 1 commit into from
Nov 9, 2023

Conversation

zachariahmiller
Copy link
Contributor

@zachariahmiller zachariahmiller commented Nov 9, 2023 •
edited
Loading

Description

fix release please json as glob + yaml file type doesn't work for us right now. Look to add back the glob based file references once googleapis/release-please#2125 has been implemented

Related Issue

Fixes #

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@jeff-mccoy jeff-mccoy merged commit 23f4999 into main Nov 9, 2023
2 checks passed
@jeff-mccoy jeff-mccoy deleted the release_pretty_please branch November 9, 2023 23:13
@github-actions github-actions bot mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-mccoy jeff-mccoy jeff-mccoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachariahmiller @jeff-mccoy