-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(operator): add events and improve lifecycle ops #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note the behavior in this PR won't permanently resolve CR resync on pod restart until Pepr #643 is released. However, because the inner function contents are changing with this PR, the resync will occur on upgrade the first time. |
mjnagel
reviewed
Mar 14, 2024
mjnagel
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - the events on failure are a big plus.
rjferguson21
approved these changes
Mar 15, 2024
mjnagel
pushed a commit
that referenced
this pull request
Mar 15, 2024
🤖 I have created a release *beep* *boop* --- ## [0.16.0](v0.15.1...v0.16.0) (2024-03-15) ### Features * add velero package ([#210](#210)) ([a272945](a272945)) * **operator:** add events and improve lifecycle ops ([#245](#245)) ([502c044](502c044)) ### Bug Fixes * ocsp lookup egress policy ([#255](#255)) ([77c38f2](77c38f2)) ### Miscellaneous * add flavor to pepr build task ([#238](#238)) ([29bf8a3](29bf8a3)) * **deps:** update grafana ([#144](#144)) ([6987927](6987927)) * **deps:** update neuvector ([#73](#73)) ([50f6c90](50f6c90)) * test artifacts before publish ([#198](#198)) ([9732f32](9732f32)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robmcelvenny
pushed a commit
to owen-grady/uds-core-slim-dev
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.16.0](defenseunicorns/uds-core@v0.15.1...v0.16.0) (2024-03-15) ### Features * add velero package ([#210](defenseunicorns/uds-core#210)) ([a272945](defenseunicorns/uds-core@a272945)) * **operator:** add events and improve lifecycle ops ([#245](defenseunicorns/uds-core#245)) ([502c044](defenseunicorns/uds-core@502c044)) ### Bug Fixes * ocsp lookup egress policy ([#255](defenseunicorns/uds-core#255)) ([77c38f2](defenseunicorns/uds-core@77c38f2)) ### Miscellaneous * add flavor to pepr build task ([#238](defenseunicorns/uds-core#238)) ([29bf8a3](defenseunicorns/uds-core@29bf8a3)) * **deps:** update grafana ([#144](defenseunicorns/uds-core#144)) ([6987927](defenseunicorns/uds-core@6987927)) * **deps:** update neuvector ([#73](defenseunicorns/uds-core#73)) ([50f6c90](defenseunicorns/uds-core@50f6c90)) * test artifacts before publish ([#198](defenseunicorns/uds-core#198)) ([9732f32](defenseunicorns/uds-core@9732f32)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rjferguson21
pushed a commit
that referenced
this pull request
Jul 11, 2024
This PR enables stronger idempotent patterns with the automatic reprocessing of all CRs when seen for the first time on a new pod boot. It also adds better error data in the form of K8s event creation in when failures occur. Lastly some code refactoring for the reconcilers was done in addition to more unit tests added. --------- Co-authored-by: Tristan Holaday <40547442+TristanHoladay@users.noreply.github.com> Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
rjferguson21
pushed a commit
that referenced
this pull request
Jul 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.16.0](v0.15.1...v0.16.0) (2024-03-15) ### Features * add velero package ([#210](#210)) ([a272945](a272945)) * **operator:** add events and improve lifecycle ops ([#245](#245)) ([502c044](502c044)) ### Bug Fixes * ocsp lookup egress policy ([#255](#255)) ([77c38f2](77c38f2)) ### Miscellaneous * add flavor to pepr build task ([#238](#238)) ([29bf8a3](29bf8a3)) * **deps:** update grafana ([#144](#144)) ([6987927](6987927)) * **deps:** update neuvector ([#73](#73)) ([50f6c90](50f6c90)) * test artifacts before publish ([#198](#198)) ([9732f32](9732f32)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables stronger idempotent patterns with the automatic reprocessing of all CRs when seen for the first time on a new pod boot. It also adds better error data in the form of K8s event creation in when failures occur. Lastly some code refactoring for the reconcilers was done in addition to more unit tests added.