Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: podmonitor mTLS mutations #566

Merged
merged 7 commits into from
Jul 12, 2024
Merged

fix: podmonitor mTLS mutations #566

merged 7 commits into from
Jul 12, 2024

Conversation

mjnagel
Copy link
Contributor

@mjnagel mjnagel commented Jul 12, 2024

Description

This PR has a few follow-on changes for #517:

  • Slightly reworded/ordered documentation to focus on current setup rather than deprecated setup
  • Updated code to support podSelector or selector for pod monitor generation
  • Updated mutation logic for servicemonitors to:
    • Combine conditionals for exemption
    • Add a new uds/skip-mutate annotation for exemption
    • Clarify deprecation of tlsConfig mutation (not scheme)
  • Added mutation logic for podmonitors to:
    • Allow for exempting podmonitors from default scrape class via annotation or injection detection
    • Mutate scheme to https if not exempted
  • Switched core podmonitors to use uds/skip-mutate annotation rather than explicit scrape class
  • Deleted example test monitoring from other test-apps and enabled pod + svc monitor for podinfo (since it exposes a real metrics endpoint)

Related Issue

No issue opened as this PR was just merged.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@mjnagel mjnagel self-assigned this Jul 12, 2024
@mjnagel mjnagel merged commit eb613e1 into main Jul 12, 2024
11 checks passed
@mjnagel mjnagel deleted the podmonitor-exemption branch July 12, 2024 18:20
@github-actions github-actions bot mentioned this pull request Jul 12, 2024
Merged
mjnagel pushed a commit that referenced this pull request Jul 12, 2024
@github-actions
chore(main): release 0.24.0 (#550)
fb365cf 
🤖 I have created a release *beep* *boop*
---


##
[0.24.0](v0.23.0...v0.24.0)
(2024-07-12)


### ⚠ BREAKING CHANGES

* set istio passthrough gateway as optional component
(#547)

### Features

* add unicorn flavor to uds-core
([#507](#507))
([a412581](a412581))
* added standalone dns service for loki
([#548](#548))
([e2efdf9](e2efdf9))
* enable authservice integration
([#201](#201))
([1d4df64](1d4df64))
* set istio passthrough gateway as optional component
(#547)
([e1cab61](e1cab61))
* update to using default scrapeclass for tls config
([#517](#517))
([258bb6b](258bb6b))


### Bug Fixes

* decouple `devMode` and postgres egress
([#554](#554))
([1a98779](1a98779))
* grafana logout not working in some environments
([#559](#559))
([ccb9d9e](ccb9d9e))
* initial creation of child logging
([#533](#533))
([00a5140](00a5140))
* podmonitor mTLS mutations
([#566](#566))
([eb613e1](eb613e1))


### Miscellaneous

* add util function for purging orphans
([#565](#565))
([e84229a](e84229a))
* allow istio proxy injection in zarf ignored namespaces
(#513)
([8921b58](8921b58))
* **deps:** update githubactions upload-artifact to v4.3.4
([#543](#543))
([20889f2](20889f2))
* **deps:** update grafana helm chart to v8.3.2
([#542](#542))
([8ec260c](8ec260c))
* **deps:** update pepr dependencies (jest, uds-common)
([#537](#537))
([547c0bf](547c0bf))
* **deps:** update promtail helm chart to v6.16.3
([#538](#538))
([48b3fea](48b3fea))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjferguson21 rjferguson21 rjferguson21 approved these changes

@MxNxPx MxNxPx Awaiting requested review from MxNxPx

@UnicornChance UnicornChance Awaiting requested review from UnicornChance

Assignees

@mjnagel mjnagel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjnagel @rjferguson21