From 9518cd9d3ec614730e440e04ccfd0913a29414d8 Mon Sep 17 00:00:00 2001 From: excaliborr Date: Wed, 21 Aug 2024 09:41:16 -0400 Subject: [PATCH 1/2] chore: add chain name to initalizeV2 in script --- README.md | 3 ++- script/mainnet/deploy/Deploy.s.sol | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index e568297..cf1573c 100644 --- a/README.md +++ b/README.md @@ -112,8 +112,9 @@ After all these variables are set, navigate to the `script/mainnet/Deploy.s.sol` // NOTE: We have these hardcoded to default values, if used in product you will need to change them bytes[] memory _usdcInitTxs = new bytes[](3); + string memory _name = string.concat('Bridged USDC, ' ', '(', chainName, ')'); - _usdcInitTxs[0] = USDCInitTxs.INITIALIZEV2; + _usdcInitTxs[0] = abi.encodeCall(IUSDC.initializeV2, (_name)); _usdcInitTxs[1] = USDCInitTxs.INITIALIZEV2_1; _usdcInitTxs[2] = USDCInitTxs.INITIALIZEV2_2; diff --git a/script/mainnet/deploy/Deploy.s.sol b/script/mainnet/deploy/Deploy.s.sol index cdbba84..72f8126 100644 --- a/script/mainnet/deploy/Deploy.s.sol +++ b/script/mainnet/deploy/Deploy.s.sol @@ -4,6 +4,7 @@ pragma solidity 0.8.25; import {Script} from 'forge-std/Script.sol'; import {console} from 'forge-std/Test.sol'; import {IL1OpUSDCFactory} from 'interfaces/IL1OpUSDCFactory.sol'; +import {IUSDC} from 'interfaces/external/IUSDC.sol'; import {USDCInitTxs} from 'src/contracts/utils/USDCInitTxs.sol'; contract Deploy is Script { @@ -21,8 +22,9 @@ contract Deploy is Script { // NOTE: We have these hardcoded to default values, if used in product you will need to change them bytes[] memory _usdcInitTxs = new bytes[](3); + string memory _name = string.concat('Bridged ', ' ', '(', chainName, ')'); - _usdcInitTxs[0] = USDCInitTxs.INITIALIZEV2; + _usdcInitTxs[0] = abi.encodeCall(IUSDC.initializeV2, (_name)); _usdcInitTxs[1] = USDCInitTxs.INITIALIZEV2_1; _usdcInitTxs[2] = USDCInitTxs.INITIALIZEV2_2; From aab5192131af4f2de4323dc6e8307f3ce1cf9621 Mon Sep 17 00:00:00 2001 From: excaliborr Date: Wed, 21 Aug 2024 09:44:49 -0400 Subject: [PATCH 2/2] fix: typo --- README.md | 2 +- script/mainnet/deploy/Deploy.s.sol | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index cf1573c..260dd35 100644 --- a/README.md +++ b/README.md @@ -112,7 +112,7 @@ After all these variables are set, navigate to the `script/mainnet/Deploy.s.sol` // NOTE: We have these hardcoded to default values, if used in product you will need to change them bytes[] memory _usdcInitTxs = new bytes[](3); - string memory _name = string.concat('Bridged USDC, ' ', '(', chainName, ')'); + string memory _name = string.concat('Bridged USDC', ' ', '(', chainName, ')'); _usdcInitTxs[0] = abi.encodeCall(IUSDC.initializeV2, (_name)); _usdcInitTxs[1] = USDCInitTxs.INITIALIZEV2_1; diff --git a/script/mainnet/deploy/Deploy.s.sol b/script/mainnet/deploy/Deploy.s.sol index 72f8126..02083ea 100644 --- a/script/mainnet/deploy/Deploy.s.sol +++ b/script/mainnet/deploy/Deploy.s.sol @@ -22,7 +22,7 @@ contract Deploy is Script { // NOTE: We have these hardcoded to default values, if used in product you will need to change them bytes[] memory _usdcInitTxs = new bytes[](3); - string memory _name = string.concat('Bridged ', ' ', '(', chainName, ')'); + string memory _name = string.concat('Bridged USDC', ' ', '(', chainName, ')'); _usdcInitTxs[0] = abi.encodeCall(IUSDC.initializeV2, (_name)); _usdcInitTxs[1] = USDCInitTxs.INITIALIZEV2_1;