feat(*): build the control loop & state machine for fulfilling claims #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arschles
force-pushed
the
cm-control-loop
branch
from
e5174ee
to
67280e0
Compare
for watching config maps that have claims in them. also document state transitions
arschles
force-pushed
the
cm-control-loop
branch
from
67280e0
to
7ae0a0a
Compare
added 17 commits
August 16, 2016 10:09
an interface designed to do provision/deprovision/bind/unbind, so you don’t have to pass all 4 separate interfaces
given the new lifecycler interface
and ConfigMapsNamespacer throughout the codebase
…and namespace to the claim so that steward knows where to write the credentials config map
in preparation for implementing the config loop
in favor of a ./k8s/claim package global logger
from service catalog entry
… IDs also: - make it store the instance and bind IDs that were used - add keys for various statuses and implement much of the creation logic in the control loop - modify the documentation to include the instance/bind IDs (marked as internal use only)
this makes the high level process logic more readable
this reduces cyclomatic complexity and makes the logic around the processEvent call clearer
Closed
added 6 commits
August 16, 2016 12:35
instead of passing errors
on completion of each step
added 3 commits
August 16, 2016 15:35
to account for the fact that a steward may crash, or be launched during a create or delete operation
and fixing a bug that the tests found
added 6 commits
August 16, 2016 16:08
On the service plan claim wrapper. Also, add and use an original name field
This was referenced Aug 17, 2016
added 5 commits
August 17, 2016 12:26
and add labels
This was referenced Aug 17, 2016
added 8 commits
August 17, 2016 13:12
This is a sub-optimal fix. The optimization is at deis/steward#85
The tests are TODO
…Stringer this commit makes logging easier to read
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
Fixes #7
Fixes #74
Closes #22
Ref #68
TODO:
deis/master(k8s.io/kubernetes/pkg/client/unversioned).ConfigMapsInterfacein code, instead of the hand-rolledConfigMapCreatorDeleter, etc... interfaces in./k8s./k8s/claim/loop.go'sprocessEventfuncServicePlanClaimFromMap