-
Notifications
You must be signed in to change notification settings - Fork 180
WIP: declare "off_cluster_minio" #857
base: master
Are you sure you want to change the base?
Conversation
for an External minio server using s3.accesskey and s3.secretkey, will add s3.regionendpoint later WIP: to resolve deis#481 More changes will go in deis/builder deis/controller deis/database deis/registry, all of which have dependencies on s3/swift storage (In PoC I overrode DEIS_MINIO_SERVICE_HOST and DEIS_MINIO_SERVICE_PORT, I'd like to use that shortcut and it seems safe, but expose it in values as s3.regionendpoint, reorganizing values.yaml so the off-cluster minio configuration is very obvious.)
Values.global.storage "minio" <-- is this value read and used anywhere other than in If not, we can just pick a different value instead of "minio" so that it will be distinct from internal minio. https://gist.github.com/kingdonb/845945908336cbeefb3e8cce73ec5dc2 These changes were all I needed to enable off-cluster minio on my local/minikube Workflow instance. (I deleted the
... did not work the way that I expected. I will gladly take pointers on gotl and improve this before merge. WIP. |
I thought I had better get some feedback before I went to the trouble and opened four separate pull requests on deis/builder, deis/registry, deis/database, and deis/controller... please take a look at my patch and suggest alternatives if you think it is not in good shape to merge. The better approach is probably not to try overwriting kubernetes service host and port variables... but I am new at this. |
This will be better if I follow the guidance in #481 more closely, namely the part about setting |
Jenkins, add to whitelist. |
Related to deis/monitor#191 If you want to support a cloud-neutral storage for swift objects, to be complete would also need to provide an answer for block storage or at least for the storage requirements of Grafana and InfluxDB |
Jenkins, test this please |
for an External minio server using s3.accesskey and s3.secretkey,
will add s3.regionendpoint later
WIP: to resolve #481
More changes will go in deis/builder deis/controller deis/database
deis/registry, all of which have dependencies on s3/swift storage
In PoC I overrode DEIS_MINIO_SERVICE_HOST and DEIS_MINIO_SERVICE_PORT
I'd like to use that shortcut and it seems safe, but I'm open to doing it another way if it's cleaner. I would decompose host and port from value in s3.regionendpoint, reorganizing values.yaml so the off-cluster minio configuration is very obvious.
I could not reliably use Deis Workflow on any of my (relatively not-top-of-the-line) portable machines via minikube or minishift without adding a remote storage server for minio, and adding some persistent disk. Can we get the configuration for this mode worked out in 2.19 final release?