This repository has been archived by the owner on Dec 9, 2022. It is now read-only.
Add secrets #6
Merged
Add secrets #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humzashah
approved these changes
Jan 16, 2018
| @@ -1,3 +1,3 @@ | |||
| package cli | |||
| //go:generate bash ./generate_version.sh | |||
| var PaddleVersion = "0.3.1" | |||
| var PaddleVersion = "0.4.7" | |||
There was a problem hiding this comment.
Good question! To test it I use goreleaser (since Jenkins will automatically download the latest release on Github), so every tested version results in a bump. Not ideal, but works. Ideally we would change it to support pre-releases.
| @@ -106,8 +108,14 @@ func Watch(ctx context.Context, c kubernetes.Interface, watchPod *v1.Pod) (<-cha | |||
| select { | |||
| case <-time.After(watchPollInterval): | |||
| pod, err := c.CoreV1().Pods(watchPod.Namespace).Get(watchPod.Name, metav1.GetOptions{}) | |||
| if err != nil { | |||
| if pod != nil { | |||
There was a problem hiding this comment.
this is the recent pod status bug we encountered?
There was a problem hiding this comment.
Yup! You're right, it should have lived in a different PR but here it is :)
|
Changes to add to the README are piling up. :) |
|
Who needs a README when you have |
ah, right! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing secrets to the pod file with
--secretoption