Add PowerMax Mount Credentials for installation with Operator #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

falfaroc merged 6 commits into usr/spark/powermax-secret from usr/falfaroc/operator-powermax-secret

Feb 4, 2025

Contributor

falfaroc commented Jan 20, 2025 •

edited

Loading

Description

Updating install documentation to guide users through the process of installing csi-powermax using the reverse proxy secret with CSM Operator.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1614

Checklist:

Have you run a grammar and spell checks against your submission?
Have you tested the changes locally?
Have you tested whether the hyperlinks are working properly?
Did you add the examples wherever applicable?
Have you added high-resolution images?


          Add PowerMax Mount Credentials for installation with Operator

a79a753

github-actions bot commented Jan 20, 2025

Test Results

77 tests ±0 77 ✅ ±0 3s ⏱️ ±0s
3 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit a282f371. ± Comparison against base commit 34cc99a.

falfaroc changed the base branch from main to usr/spark/powermax-secret

January 21, 2025 21:13

falfaroc marked this pull request as ready for review

January 21, 2025 21:13

falfaroc requested review from AronAtDell, gallacher, mjsdell, prablr79, rajkumar-palani, rsedlock1958 and sharmilarama as code owners

January 21, 2025 21:13

falfaroc requested review from bharathsreekanth, harshitap26, lukeatdell, tdawe and xuluna

January 21, 2025 21:13

rsedlock1958 reviewed

View reviewed changes

content/docs/csidriver/features/powermax.md Outdated Show resolved Hide resolved

rsedlock1958 reviewed

View reviewed changes

content/docs/csidriver/features/powermax.md Outdated Show resolved Hide resolved

rsedlock1958 reviewed

View reviewed changes

layouts/shortcodes/message.html Outdated Show resolved Hide resolved

rsedlock1958 requested changes

View reviewed changes

rsedlock1958 left a comment

Edits are required


          Address pull request comments

d1b0876

falfaroc requested a review from rsedlock1958

January 22, 2025 20:15

lukeatdell reviewed

View reviewed changes

content/docs/deployment/csmoperator/drivers/powermax.md Outdated Show resolved Hide resolved

content/docs/deployment/csmoperator/drivers/powermax.md Outdated Show resolved Hide resolved

content/docs/deployment/csmoperator/drivers/powermax.md Outdated Show resolved Hide resolved

content/docs/deployment/csmoperator/drivers/powermax.md Outdated Show resolved Hide resolved

rsedlock1958 reviewed

View reviewed changes

content/docs/csidriver/features/powermax.md Outdated Show resolved Hide resolved

rsedlock1958 previously requested changes

View reviewed changes

rsedlock1958 left a comment

One edit is required.

anandrajak1 reviewed

View reviewed changes

content/docs/deployment/csmoperator/drivers/powermax.md Outdated Show resolved Hide resolved

content/docs/csidriver/features/powermax.md Outdated Show resolved Hide resolved

content/docs/csidriver/features/powermax.md Outdated Show resolved Hide resolved

content/docs/csidriver/features/powermax.md Outdated Show resolved Hide resolved

content/docs/deployment/csmoperator/drivers/powermax.md Outdated Show resolved Hide resolved

layouts/shortcodes/message.html Outdated Show resolved Hide resolved

falfaroc force-pushed the usr/falfaroc/operator-powermax-secret branch from bbf245a to d1b0876 Compare

January 24, 2025 16:51


          Add deprecation banner to helm installation for Powermax

919fa9e

falfaroc requested review from anandrajak1 and lukeatdell

January 24, 2025 16:58

falfaroc requested a review from rsedlock1958

January 24, 2025 16:58


          Fix link path

c55de1e

rsedlock1958 reviewed

View reviewed changes

rsedlock1958 left a comment

I have reviewed this. No grammatical edits are required.

lukeatdell reviewed

View reviewed changes

content/docs/csidriver/features/powermax.md Show resolved Hide resolved

content/docs/deployment/csmoperator/drivers/powermax.md Show resolved Hide resolved


          Add certSecret for mount credentials

67675c9

falfaroc dismissed rsedlock1958’s stale review

January 24, 2025 21:03

Address.

falfaroc requested review from lukeatdell and rsedlock1958

January 24, 2025 21:03

lukeatdell approved these changes

View reviewed changes

bharathsreekanth previously requested changes

View reviewed changes

content/docs/csidriver/features/powermax.md Show resolved Hide resolved


          Add limits to secret

57a357f

falfaroc requested review from bharathsreekanth and lukeatdell

February 3, 2025 13:21

lukeatdell approved these changes

View reviewed changes

falfaroc dismissed bharathsreekanth’s stale review

February 3, 2025 21:44

Addressed.

falfaroc merged commit 3104981 into usr/spark/powermax-secret

falfaroc deleted the usr/falfaroc/operator-powermax-secret branch

February 4, 2025 13:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lukeatdell lukeatdell approved these changes

gallacher Awaiting requested review from gallacher

mjsdell Awaiting requested review from mjsdell

prablr79 Awaiting requested review from prablr79

rajkumar-palani Awaiting requested review from rajkumar-palani

AronAtDell Awaiting requested review from AronAtDell

sharmilarama Awaiting requested review from sharmilarama

tdawe Awaiting requested review from tdawe

xuluna Awaiting requested review from xuluna

harshitap26 Awaiting requested review from harshitap26

anandrajak1 Awaiting requested review from anandrajak1

rsedlock1958 Awaiting requested review from rsedlock1958

bharathsreekanth Awaiting requested review from bharathsreekanth

Labels

None yet