Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powermax doc update on reverse proxy cert #1431

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

karthikk92
Copy link
Contributor

Description

Powermax doc update on reverse proxy cert

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1698

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

Copy link

github-actions bot commented Jan 23, 2025

Test Results

77 tests  ±0   77 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 5e7512b. ± Comparison against base commit 34cc99a.

♻️ This comment has been updated with latest results.

@sharmilarama
Copy link
Contributor

@karthikk92 All dev changes need to first be merged in to main branch for the current release. The changes can then be back ported to the release 1.13 branch.

@karthikk92
Copy link
Contributor Author

The changes can then be back ported to the release 1.13 branch.
@sharmilarama main changes are merged. #1426

Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Copy link
Contributor

@sharmilarama sharmilarama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cherry pick the changes from main branch, PR should not be coming directly from dev branch to release branch.

Copy link
Contributor

@sharmilarama sharmilarama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, going forward please separate commits for v1 folder changes going into main. This will allow easier cherry picking.

@rajkumar-palani rajkumar-palani merged commit 1209497 into release-1.13.0 Jan 27, 2025
7 checks passed
@rajkumar-palani rajkumar-palani deleted the usr/kk3/rev_proxy_cert_updates branch January 27, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants