-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align CRD in Deploy Folder with Generated CRDs #874
Conversation
Did you run the E2E test scenario you fixed? |
@jooseppi-luna Currently running e2e tests verifying changes. Only actual code change is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Description
Update the CRDs in the
deploy
folder with the autogenerated CRDs from theconfig
folder.Note: Most of the changes are formatting descriptions. Main change, the replicas default to
2
for CRs that don't a replica field. This would be most important forminimal manifest
since this is not supplied.GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
With Fix
Without Fix and E2E Error