Skip to content

Conversation

@khareRajshree
Copy link
Contributor

@khareRajshree khareRajshree commented Feb 10, 2025

Description

GitHub action created to trigger Go client library release action.

Issues

List the issues impacted by this PR:

Issue ID
https://github.com/dell/csm/issues/1490

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

Changes are tested on forked repo.
GH action triggered from forked common-github-actions repo: https://github.com/khareRajshree/common-github-actions/actions/runs/13437785133 which further triggered the workflows of individual repos.

image

@shaynafinocchiaro
Copy link
Collaborator

Fix lint warning on: # yamllint disable-line rule:truthy

@khareRajshree
Copy link
Contributor Author

Fix lint warning on: # yamllint disable-line rule:truthy

Updated in recent commit.

niranjan-n1
niranjan-n1 previously approved these changes Apr 2, 2025
samihan-dell
samihan-dell previously approved these changes Apr 2, 2025
repository_dispatch:
types: [release-go-libs]
jobs:
package-update:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment above this step as to why its needed? Since this is slightly different from other release workflows for golibs, it can get confusing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

harishp8889
harishp8889 previously approved these changes Apr 2, 2025
@khareRajshree khareRajshree merged commit a383585 into main Apr 2, 2025
6 checks passed
@khareRajshree khareRajshree deleted the usr/khareRajshree/golibs-release-workflow branch April 2, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants