Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UT coverage #264

Closed
wants to merge 47 commits into from
Closed

Improve UT coverage #264

wants to merge 47 commits into from

Conversation

niranjan-n1
Copy link
Contributor

@niranjan-n1 niranjan-n1 commented Feb 6, 2025 •
edited by chaganti-rajitha
Loading

Description

Increasing UT coverage to 90%

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

niranjan-n1 and others added 30 commits February 6, 2025 13:38
@niranjan-n1
updated UT
a043f34
@niranjan-n1
increased k8sapi coverage to 8.9%
6fa1cb6
@niranjan-n1
improved k8sapi coverage to 18%
b359870
@niranjan-n1
increased k8sapi coverage to 40.2%
b3759ab
@niranjan-n1
improved k8sapi coverage to 41.9%
54d2be3
@chaganti-rajitha
increased coverage of csiapi from 7.8 to 37.3
234cebc
@chaganti-rajitha
commented failing test case
3ec6084
@samihan-dell
test: Updated unit tests for criapi.go
62b14a1
@chaganti-rajitha
added utils test files
2075b33
@samihan-dell
test: Increased unit tests for criapi.go from 0% to 40%
334e8dc
@samihan-dell
Merge branch 'UT_Coverage' of https://github.com/dell/karavi-resiliency…
e9c1238 
… into UT_Coverage
@samihan-dell
test: Increased unit tests coverage for criapi.go
25563dd
@samihan-dell
test: Increased unit tests coverage for criapi.go from 37% to 49%
8a2ae62
@chaganti-rajitha
increased csi UT coverage to 46.2
e23156f
@chaganti-rajitha
fixed failing test case
9ff3d4f
@niranjan-n1
added unit test for mock.go
d18b72f
@niranjan-n1
update k8scri coverage to 46.4%
9ff927f
@niranjan-n1
update k8scri coverage to 46.4%
749bc79
@satyakonduri
consolidate mock files in mocks directory
6dbf691
@chaganti-rajitha @satyakonduri
added utils test files
c14a997
@samihan-dell @satyakonduri
test: Increased unit tests coverage for criapi.go
5b6a2cf
@samihan-dell @satyakonduri
test: Increased unit tests coverage for criapi.go from 37% to 49%
82749ee
@chaganti-rajitha @satyakonduri
increased csi UT coverage to 46.2
4dd9a1c
@chaganti-rajitha @satyakonduri
fixed failing test case
bc6dcb3
@niranjan-n1 @satyakonduri
added unit test for mock.go
d866235
@niranjan-n1 @satyakonduri
update k8scri coverage to 46.4%
b821c52
@niranjan-n1 @satyakonduri
update k8scri coverage to 46.4%
301119b
@satyakonduri
consolidate mock files in mocks directory
34b57b8
@satyakonduri
Merge branch 'UT_Coverage' of https://github.com/dell/karavi-resiliency…
fd9b5c6 
… into UT_Coverage
@satyakonduri
Merge branch 'UT_Coverage' of https://github.com/dell/karavi-resiliency…
dcd6466 
… into UT_Coverage
@chaganti-rajitha chaganti-rajitha marked this pull request as ready for review February 27, 2025 13:01
@donatwork
Copy link
Contributor

There are unverified commits. This branch should be merged to a new branch and the commit signed. The use that branch for the PR.

@satyakonduri
Copy link
Contributor

New PR: #271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alikdell alikdell alikdell approved these changes

@EvgenyUglov EvgenyUglov EvgenyUglov approved these changes

@anandrajak1 anandrajak1 anandrajak1 approved these changes

@atye atye Awaiting requested review from atye atye is a code owner

@anathoodell anathoodell Awaiting requested review from anathoodell anathoodell is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@alexemc alexemc Awaiting requested review from alexemc alexemc is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@niranjan-n1 @donatwork @satyakonduri @alikdell @EvgenyUglov @anandrajak1 @chaganti-rajitha @samihan-dell @sidharth30060