Skip to content

Commit 0b6c14b

Browse files
committed
SUNRPC: Make cache_req::thread_wait an unsigned long
The second parameter of wait_for_completion_interruptible_timeout() is a jiffies value whose type is "unsigned long". Avoid an unnecessary and potentially fraught implicit type conversion at the wait_for_completion_interruptible_timeout() call site in cache_wait_req(). Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent 37324e6 commit 0b6c14b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

include/linux/sunrpc/cache.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,17 +121,17 @@ struct cache_detail {
121121
struct net *net;
122122
};
123123

124-
125124
/* this must be embedded in any request structure that
126125
* identifies an object that will want a callback on
127126
* a cache fill
128127
*/
129128
struct cache_req {
130129
struct cache_deferred_req *(*defer)(struct cache_req *req);
131-
int thread_wait; /* How long (jiffies) we can block the
132-
* current thread to wait for updates.
133-
*/
130+
unsigned long thread_wait; /* How long (jiffies) we can block the
131+
* current thread to wait for updates.
132+
*/
134133
};
134+
135135
/* this must be embedded in a deferred_request that is being
136136
* delayed awaiting cache-fill
137137
*/

0 commit comments

Comments
 (0)