Skip to content

Commit a1e24c3

Browse files
lgtuxksacilotto
authored andcommitted
staging: rtl8192e: Fix possible buffer overflow in _rtl92e_wx_set_scan
BugLink: https://bugs.launchpad.net/bugs/1920246 commit 8687bf9 upstream. Function _rtl92e_wx_set_scan calls memcpy without checking the length. A user could control that length and trigger a buffer overflow. Fix by checking the length is within the maximum allowed size. Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Lee Gibson <leegib@gmail.com> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20210226145157.424065-1-leegib@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Kamal Mostafa <kamal@canonical.com> Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
1 parent cac9584 commit a1e24c3

File tree

1 file changed

+4
-3
lines changed
  • drivers/staging/rtl8192e/rtl8192e

1 file changed

+4
-3
lines changed

drivers/staging/rtl8192e/rtl8192e/rtl_wx.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -406,9 +406,10 @@ static int _rtl92e_wx_set_scan(struct net_device *dev,
406406
struct iw_scan_req *req = (struct iw_scan_req *)b;
407407

408408
if (req->essid_len) {
409-
ieee->current_network.ssid_len = req->essid_len;
410-
memcpy(ieee->current_network.ssid, req->essid,
411-
req->essid_len);
409+
int len = min_t(int, req->essid_len, IW_ESSID_MAX_SIZE);
410+
411+
ieee->current_network.ssid_len = len;
412+
memcpy(ieee->current_network.ssid, req->essid, len);
412413
}
413414
}
414415

0 commit comments

Comments
 (0)