drm/amdgpu: Fix comparison in amdgpu_res_cpu_visible

Michel Dänzer · alexdeucher · commit c4dcb47d4614 · 2024-05-08T18:45:29.000-04:00
It incorrectly claimed a resource isn't CPU visible if it's located at the very end of CPU visible VRAM. Fixes: a6ff969 ("drm/amdgpu: fix visible VRAM handling during faults") Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3343 Reviewed-by: Christian König <christian.koenig@amd.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Reported-and-Tested-by: Jeremy Day <jsday@noreason.ca> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> CC: stable@vger.kernel.org
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -432,7 +432,7 @@ bool amdgpu_res_cpu_visible(struct amdgpu_device *adev,
 
 	amdgpu_res_first(res, 0, res->size, &cursor);
 	while (cursor.remaining) {
-		if ((cursor.start + cursor.size) >= adev->gmc.visible_vram_size)
+		if ((cursor.start + cursor.size) > adev->gmc.visible_vram_size)
 			return false;
 		amdgpu_res_next(&cursor, cursor.size);
 	}

Original file line number	Diff line number	Diff line change
`@@ -432,7 +432,7 @@ bool amdgpu_res_cpu_visible(struct amdgpu_device *adev,`
`432`	`432`
`433`	`433`	`amdgpu_res_first(res, 0, res->size, &cursor);`
`434`	`434`	`while (cursor.remaining) {`
`435`		`- if ((cursor.start + cursor.size) >= adev->gmc.visible_vram_size)`
	`435`	`+ if ((cursor.start + cursor.size) > adev->gmc.visible_vram_size)`
`436`	`436`	`return false;`
`437`	`437`	`amdgpu_res_next(&cursor, cursor.size);`
`438`	`438`	`}`