Skip to content

Commit dff655e

Browse files
Jijie Shaodavem330
authored andcommitted
net: hns3: fix VF wrong speed and duplex issue
If PF is down, firmware will returns 10 Mbit/s rate and half-duplex mode when PF queries the port information from firmware. After imp reset command is executed, PF status changes to down, and PF will query link status and updates port information from firmware in a periodic scheduled task. However, there is a low probability that port information is updated when PF is down, and then PF link status changes to up. In this case, PF synchronizes incorrect rate and duplex mode to VF. This patch fixes it by updating port information before PF synchronizes the rate and duplex to the VF when PF changes to up. Fixes: 18b6e31 ("net: hns3: PF add support for pushing link status to VFs") Signed-off-by: Jijie Shao <shaojijie@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 65e98bb commit dff655e

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ static void hclge_sync_fd_table(struct hclge_dev *hdev);
6161
static void hclge_update_fec_stats(struct hclge_dev *hdev);
6262
static int hclge_mac_link_status_wait(struct hclge_dev *hdev, int link_ret,
6363
int wait_cnt);
64+
static int hclge_update_port_info(struct hclge_dev *hdev);
6465

6566
static struct hnae3_ae_algo ae_algo;
6667

@@ -3041,6 +3042,9 @@ static void hclge_update_link_status(struct hclge_dev *hdev)
30413042

30423043
if (state != hdev->hw.mac.link) {
30433044
hdev->hw.mac.link = state;
3045+
if (state == HCLGE_LINK_STATUS_UP)
3046+
hclge_update_port_info(hdev);
3047+
30443048
client->ops->link_status_change(handle, state);
30453049
hclge_config_mac_tnl_int(hdev, state);
30463050
if (rclient && rclient->ops->link_status_change)

0 commit comments

Comments
 (0)